Adding API server support for service account #1143
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blublinsky
changed the title
|
@kevin85421, can you, please, take a look at the errors? They all come from the operator, not my code |
|
Oh, I found that the master branch is also broken. It's a bit weird because all merged PRs pass all CI tests. I will draft a PR to fix it. Sorry for the inconvenience. |
|
#1145 is merged. Would you mind rebasing with the master branch? However, I found the nightly compatibility to be quite unstable. There may have been some recent breaking changes in the Ray master branch. |
|
/assign |
Jeffwan
requested changes
Jun 6, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Current implementation of the operator supports usage of the service accounts, while API server has no ability to specify it. This PR adds Service account parameter to head and worker nodes definitions and propagate them to corresponding pod templates
Related issue number
Checks