Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #1145

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Fix CI #1145

merged 1 commit into from
Jun 6, 2023

Conversation

kevin85421
Copy link
Member

Why are these changes needed?

I merged #1128 after it passed all CI tests. However, the post-merge tests failed because I didn't rebase with the master branch.

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@kevin85421
Copy link
Member Author

I retried the nightly test three times, but it keeps failing. The Ray master branch may have introduced some breaking changes that affect compatibility. Merge this before passing the nightly test because: (1) several contributors are blocked by this PR (2) the change in this PR is safe to merge. cc @architkulkarni

@kevin85421 kevin85421 merged commit 35fe6f9 into ray-project:master Jun 6, 2023
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants