Removed use of the of BUILD_FLAGS in apiserver makefile #1336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed use of variables used in building BUILD_FLAGS Fixes ray-project#1335
|
@blublinsky, @tedhtchang, @scarlet25151 and @anishasthana cc: @kevin85421 |
tedhtchang
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
Update: I was able to replicate the issue. It happens when I newly clone the repo from the my own fork without adding the remote upstream repo because the tags are coming from the remote.
git clone [email protected]:tedhtchang/kuberay.git
cd kuberay/apiserver
git tag # returns nothing
make build
fatal: No names found, cannot describe anything.
Verified make build ran fine with the change.
blublinsky
pushed a commit
to blublinsky/kuberay
that referenced
this pull request
Aug 22, 2023
…1336) Removed use of the of BUILD_FLAGS in apiserver makefile
blublinsky
pushed a commit
to blublinsky/kuberay
that referenced
this pull request
Aug 25, 2023
…1336) Removed use of the of BUILD_FLAGS in apiserver makefile
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
…1336) Removed use of the of BUILD_FLAGS in apiserver makefile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed use of variables used in building BUILD_FLAGS
Why are these changes needed?
When the tags are not available in the git repo the makefile an error is reported.
Related issue number
Fixes #1335
Closes #1335
Checks