Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed use of the of BUILD_FLAGS in apiserver makefile #1336

Merged
merged 2 commits into from
Aug 18, 2023
Merged

Removed use of the of BUILD_FLAGS in apiserver makefile #1336

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a2e40a
Removed use of the of BUILD_FLAGS
z103cb Aug 16, 2023
f1144d2
Reverted changes to un-related files.
z103cb Aug 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions apiserver/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,17 +62,8 @@ lint: golangci-lint fmt vet fumpt imports ## Run the linter.

##@ Build

COMMIT := $(shell git rev-parse --short HEAD)
VERSION := $(shell git describe --tags $(shell git rev-list --tags --max-count=1))
DATE=$(shell date -u +'%Y-%m-%dT%H:%M:%SZ')
REPO=github.com/ray-project/kuberay

BUILD_FLAGS ?= -ldflags="-X '${REPO}/apiserver/cmd/version.Version=$(VERSION)' \
-X '${REPO}/apiserver/cmd/version.gitCommit=$(COMMIT)' \
-X '${REPO}/apiserver/cmd/version.buildDate=$(DATE)'"

build: fmt vet fumpt imports lint ## Build api server binary.
go build $(BUILD_FLAGS) -o ${REPO_ROOT_BIN}/kuberay-apiserver cmd/main.go
go build -o ${REPO_ROOT_BIN}/kuberay-apiserver cmd/main.go

run: fmt vet fumpt imports lint ## Run the api server from your host.
go run -race cmd/main.go
Expand Down
Loading