Drop unused permission + configurable binary path #2478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR! Would you mind fixing the CI error? Our RBAC has two versions: role / rolebinding and clusterrole / clusterrolebinding. They need to be consistent. |
Configmaps have no status; omiting this to avoid operator having to be granted that non existing subresource: https://github.com/kubernetes/kubernetes/blob/v1.31.2/pkg/apis/core/types.go#L1722-L1743 ``` $ kubectl get configmap --subresource status myconfigmap # k8s v1.28 Error from server (NotFound): the server could not find the requested resource ``` Supporting overriding the operator's binary path can be useful for custom rebuilds, or using a wrapper, ...
bpineau
force-pushed
the
bp/overridable-command
branch
from
f5d60b1
to
f4e08a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Checks
That's chart only change: