Update envtest to support build on M1 machine #366
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmmm looks like that version doesn't quite work. @brucez-anyscale how did you get the |
I think the go version is still 1.17 for kuberay. I do not know special things for local m1 build. |
| echo "Downloading $(2)" ;\ | ||
| GOBIN=$(PROJECT_DIR)/bin go get $(2) ;\ | ||
| echo "Downloading $(2) to $(PROJECT_DIR)/bin" ;\ | ||
| GOBIN=$(PROJECT_DIR)/bin go install $(2) ;\ |
There was a problem hiding this comment.
this is go 1.17 and go 1.18 difference.
|
ahhh i see the issue now; i'll downgrade to go 1.17 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
makeon m1 mac.go getwithgo installto ensureMakefileworking. (localgo version go1.18.3 darwin/arm64)Related issue number
Checks