Update tests for better Mac M1 compatibility

[shrekris-anyscale]

Signed-off-by: Shreyas Krishnaswamy [email protected]

Why are these changes needed?

This change updates some test settings and error behavior to improve compatibility with M1 Macbooks. Thanks @simon-mo for the suggested changes!

Related issue number

Copies over some changes from #366.

Checks

• I've made sure the tests are passing.
• Testing Strategy
  • This change updates testing configurations.

[simon-mo]

@DmitriGekhtman @Jeffwan FYI

[DmitriGekhtman]

Could you explain the changes in the issue description? (I mean the details of the changes and why these fix M1 issues.)

[shrekris-anyscale]

Could you explain the changes in the issue description? (I mean the details of the changes and why these fix M1 issues.)

@simon-mo do you mind explaining the changes and why they're needed?

[simon-mo]

Sure. The envtests harness is used to run golang operator unit test. To run it, the test harness download pre-built binary from the internet. The current version in the codebase doesn't support m1. The updated override version supports it and is the earliest version that supports m1 binaries.

The comment out section in the test golang code is the fact that the cleanup step always fail and timeout in macOS. @brucez-anyscale and I have confirmed this independently and we should simply skip the harmless error. It doesn't occur on CI anyway.