Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Post Ray 2.3 Release] Update Ray versions to Ray 2.3.0 #925

Merged
merged 2 commits into from
Mar 8, 2023

Conversation

cadedaniel
Copy link
Member

Inspired by #822

I think I got all references to 2.2.0:

$ ag '2\.2\.0' | grep -v 'third_party' | grep -v 'go.sum' | grep -v 'go.mod'
CHANGELOG.md:17:* Critical stability improvements to the [Ray Autoscaler integration](https://ray-project.github.io/kuberay/guidance/autoscaler/). (To benefit from these improvements, use KubeRay >=0.4.0 and Ray >=2.2.0.)

@architkulkarni
Copy link
Contributor

@cadedaniel should we expect the tests to be passing at this point, or will they only pass after 2.3.0 is actually released?

@architkulkarni
Copy link
Contributor

Ah looks like the 2.3.0 images already exist, so I guess the tests should pass.

@@ -340,6 +340,26 @@ jobs:
with:
ray_version: 2.2.0

test-compatibility-2_3_0:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also drop the stage for Ray 2.0.0 -- current strategy is to guarantee compatibility with the last three 2.x and one 1.x

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree. too many ci jobs now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@DmitriGekhtman
Copy link
Collaborator

Ah looks like the 2.3.0 images already exist, so I guess the tests should pass.

It looks like some issues with tests of GCS HA functionality, which are historically flakey.

@kevin85421
Copy link
Member

Currently, "Compatibility Test - 2.3.0" and "Compatibility Test - Nightly" will always fail due to #852 (OOM). I will try to run the tests on my devbox to make sure the compatibility tests pass.

@kevin85421
Copy link
Member

Update:

I ran the compatibility tests on my devbox, and I still got the same error. The Ray fault tolerance in release 2.3 is incompatible with KubeRay. I will work on it immediately.

@kevin85421
Copy link
Member

This issue needs to be fixed by the Ray community. I opened an issue to track the progress #927. Happy to pair programming to help reproduce the bug.

@cadedaniel

@kevin85421
Copy link
Member

@cadedaniel #929 is merged. Would you mind rebasing the master branch?

@cadedaniel
Copy link
Member Author

Rebased and removed 2.0.0 compat test. This should be ready for merge.

@cadedaniel
Copy link
Member Author

@kevin85421 hey can you take on fixing this test? I looked at the failure log but it's not clear to me what is the problem

Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I reran the tests and they passed. The exit code is 137, and it may be related to the insufficient computing resources in the GitHub Actions free runner.

@kevin85421 kevin85421 merged commit 8da54d4 into ray-project:master Mar 8, 2023
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants