-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Post Ray 2.3 Release] Update Ray versions to Ray 2.3.0 #925
Conversation
@cadedaniel should we expect the tests to be passing at this point, or will they only pass after 2.3.0 is actually released? |
Ah looks like the 2.3.0 images already exist, so I guess the tests should pass. |
@@ -340,6 +340,26 @@ jobs: | |||
with: | |||
ray_version: 2.2.0 | |||
|
|||
test-compatibility-2_3_0: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also drop the stage for Ray 2.0.0 -- current strategy is to guarantee compatibility with the last three 2.x and one 1.x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree. too many ci jobs now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
It looks like some issues with tests of GCS HA functionality, which are historically flakey. |
Currently, "Compatibility Test - 2.3.0" and "Compatibility Test - Nightly" will always fail due to #852 (OOM). I will try to run the tests on my devbox to make sure the compatibility tests pass. |
Update: I ran the compatibility tests on my devbox, and I still got the same error. The Ray fault tolerance in release 2.3 is incompatible with KubeRay. I will work on it immediately. |
This issue needs to be fixed by the Ray community. I opened an issue to track the progress #927. Happy to pair programming to help reproduce the bug. |
@cadedaniel #929 is merged. Would you mind rebasing the master branch? |
Signed-off-by: Cade Daniel <[email protected]>
Signed-off-by: Cade Daniel <[email protected]>
Rebased and removed 2.0.0 compat test. This should be ready for merge. |
@kevin85421 hey can you take on fixing this test? I looked at the failure log but it's not clear to me what is the problem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I reran the tests and they passed. The exit code is 137, and it may be related to the insufficient computing resources in the GitHub Actions free runner.
Inspired by #822
I think I got all references to 2.2.0: