Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ray 2.3.0] Update --redis-password for RayCluster #929

Merged
merged 3 commits into from
Feb 25, 2023
Merged

[Ray 2.3.0] Update --redis-password for RayCluster #929

merged 3 commits into from
Feb 25, 2023

Conversation

kevin85421
Copy link
Member

@kevin85421 kevin85421 commented Feb 24, 2023 •
edited
Loading

Why are these changes needed?

Ray 2.3.0 changes REDIS_DEFAULT_PASSWORD from "5241590000000000" to "" in ray-project/ray#31257.

Related issue number

Closes #927
ray-project/ray#32794
#925

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

  • Ray FT related tests:

    RAY_IMAGE=rayproject/ray:2.3.0 python3 tests/compatibility-test.py RayFTTestCase 2>&1 | tee log
    Screen Shot 2023-02-24 at 11 36 24 AM

  • RayService sample YAML test:

    RAY_IMAGE=rayproject/ray:2.3.0 OPERATOR_IMAGE=kuberay/operator:nightly python3 tests/test_sample_rayservice_yamls.py 2>&1 | tee log
    Screen Shot 2023-02-24 at 11 47 08 AM

  • RayCluster sample YAML test

    RAY_IMAGE=rayproject/ray:2.3.0 OPERATOR_IMAGE=kuberay/operator:nightly python3 tests/test_sample_raycluster_yamls.py 2>&1 | tee log
    Screen Shot 2023-02-24 at 12 02 51 PM

  • Pod security test

    python3 tests/test_security.py 2>&1 | tee log
    Screen Shot 2023-02-24 at 3 42 22 PM

@kevin85421 kevin85421 changed the title WIP: Update --redis-password for RayCluster [Ray 2.3.0] Update --redis-password for RayCluster Feb 24, 2023
@kevin85421 kevin85421 marked this pull request as ready for review February 25, 2023 00:46
@kevin85421
Copy link
Member Author

cc @Yicheng-Lu-llll

@kevin85421 kevin85421 mentioned this pull request Feb 25, 2023
Closed
2 tasks
@kevin85421 kevin85421 merged commit eef1d89 into ray-project:master Feb 25, 2023
@kevin85421 kevin85421 mentioned this pull request Feb 25, 2023
Merged
@Yicheng-Lu-llll Yicheng-Lu-llll mentioned this pull request May 3, 2023
Merged
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
@kevin85421
[Ray 2.3.0] Update --redis-password for RayCluster (ray-project#929)
36b72c4 
Ray 2.3.0 changes REDIS_DEFAULT_PASSWORD from "5241590000000000" to ""
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@architkulkarni architkulkarni architkulkarni approved these changes

@DmitriGekhtman DmitriGekhtman Awaiting requested review from DmitriGekhtman

@wilsonwang371 wilsonwang371 Awaiting requested review from wilsonwang371

@gvspraveen gvspraveen Awaiting requested review from gvspraveen

@cadedaniel cadedaniel Awaiting requested review from cadedaniel

@fishbone fishbone Awaiting requested review from fishbone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Ray 2.3.0 cannot connect to Redis
2 participants
@kevin85421 @architkulkarni