-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revamp ray core design patterns doc [1/n]: generators (#27823)
- Move the code snippet to doc_code folder - Move patterns to an upper level. Signed-off-by: Jiajun Yao <[email protected]>
- Loading branch information
Showing
6 changed files
with
121 additions
and
97 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
import sys | ||
|
||
if len(sys.argv) == 1: | ||
# A small number for CI test. | ||
sys.argv.append("5") | ||
|
||
# __program_start__ | ||
import sys | ||
import ray | ||
|
||
# fmt: off | ||
# __large_values_start__ | ||
import numpy as np | ||
|
||
|
||
@ray.remote | ||
def large_values(num_returns): | ||
return [ | ||
np.random.randint(np.iinfo(np.int8).max, size=(100_000_000, 1), dtype=np.int8) | ||
for _ in range(num_returns) | ||
] | ||
# __large_values_end__ | ||
# fmt: on | ||
|
||
|
||
# fmt: off | ||
# __large_values_generator_start__ | ||
@ray.remote | ||
def large_values_generator(num_returns): | ||
for i in range(num_returns): | ||
yield np.random.randint( | ||
np.iinfo(np.int8).max, size=(100_000_000, 1), dtype=np.int8 | ||
) | ||
print(f"yielded return value {i}") | ||
# __large_values_generator_end__ | ||
# fmt: on | ||
|
||
|
||
# A large enough value (e.g. 100). | ||
num_returns = int(sys.argv[1]) | ||
# Worker will likely OOM using normal returns. | ||
print("Using normal functions...") | ||
try: | ||
ray.get( | ||
large_values.options(num_returns=num_returns, max_retries=0).remote( | ||
num_returns | ||
)[0] | ||
) | ||
except ray.exceptions.WorkerCrashedError: | ||
print("Worker failed with normal function") | ||
|
||
# Using a generator will allow the worker to finish. | ||
# Note that this will block until the full task is complete, i.e. the | ||
# last yield finishes. | ||
print("Using generators...") | ||
ray.get( | ||
large_values_generator.options(num_returns=num_returns, max_retries=0).remote( | ||
num_returns | ||
)[0] | ||
) | ||
print("Success!") |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
.. _generators: | ||
|
||
Pattern: Using generators to reduce heap memory usage | ||
===================================================== | ||
|
||
In this pattern, we use **generators** in Python to reduce the total heap memory usage during a task. The key idea is that for tasks that return multiple objects, we can return them one at a time instead of all at once. This allows a worker to free the heap memory used by a previous return value before returning the next one. | ||
|
||
Example use case | ||
---------------- | ||
|
||
You have a task that returns multiple large values. Another possibility is a task that returns a single large value, but you want to stream this value through Ray's object store by breaking it up into smaller chunks. | ||
|
||
Using normal Python functions, we can write such a task like this. Here's an example that returns numpy arrays of size 100MB each: | ||
|
||
.. literalinclude:: ../doc_code/pattern_generators.py | ||
:language: python | ||
:start-after: __large_values_start__ | ||
:end-before: __large_values_end__ | ||
|
||
However, this will require the task to hold all ``num_returns`` arrays in heap memory at the same time at the end of the task. If there are many return values, this can lead to high heap memory usage and potentially an out-of-memory error. | ||
|
||
We can fix the above example by rewriting ``large_values`` as a **generator**. Instead of returning all values at once as a tuple or list, we can ``yield`` one value at a time. | ||
|
||
.. literalinclude:: ../doc_code/pattern_generators.py | ||
:language: python | ||
:start-after: __large_values_generator_start__ | ||
:end-before: __large_values_generator_end__ | ||
|
||
Code example | ||
------------ | ||
|
||
.. literalinclude:: ../doc_code/pattern_generators.py | ||
:language: python | ||
:start-after: __program_start__ | ||
|
||
.. code-block:: text | ||
$ RAY_IGNORE_UNHANDLED_ERRORS=1 python test.py 100 | ||
Using normal functions... | ||
... -- A worker died or was killed while executing a task by an unexpected system error. To troubleshoot the problem, check the logs for the dead worker... | ||
Worker failed | ||
Using generators... | ||
(large_values_generator pid=373609) yielded return value 0 | ||
(large_values_generator pid=373609) yielded return value 1 | ||
(large_values_generator pid=373609) yielded return value 2 | ||
... | ||
Success! |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
.. _core-patterns: | ||
|
||
Design Patterns & Anti-patterns | ||
=============================== | ||
|
||
This section is a collection of common design patterns and anti-patterns for writing Ray applications. | ||
|
||
.. toctree:: | ||
:maxdepth: 1 | ||
|
||
generators |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters