Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Revamp ray core design patterns doc [1/n]: generators #27823

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

jjyao
Copy link
Collaborator

@jjyao jjyao commented Aug 12, 2022

Signed-off-by: Jiajun Yao [email protected]

Why are these changes needed?

  • Move the code snippet to doc_code folder
  • Move patterns to an upper level.

Related issue number

#27048

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@jjyao jjyao marked this pull request as ready for review August 12, 2022 17:28
@jjyao jjyao requested a review from a team as a code owner August 12, 2022 17:28
@jjyao jjyao merged commit eb37bb8 into ray-project:master Aug 15, 2022
@jjyao jjyao deleted the jjyao/pattern branch August 15, 2022 16:24
Stefan-1313 pushed a commit to Stefan-1313/ray_mod that referenced this pull request Aug 18, 2022
)

- Move the code snippet to doc_code folder
- Move patterns to an upper level.

Signed-off-by: Jiajun Yao <[email protected]>
Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants