fix single deployment benchmark #17368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edoakes
approved these changes
Jul 27, 2021
stephanie-wang
pushed a commit
to stephanie-wang/ray
that referenced
this pull request
Jul 31, 2021
DmitriGekhtman
pushed a commit
that referenced
this pull request
Aug 3, 2021
* Enforce per-node-type max workers * type annonation Co-authored-by: Ameer Haj Ali <[email protected]> * cleanup. comments. type annotations * additional type annotation Co-authored-by: Ameer Haj Ali <[email protected]> * additional cleanup. comments. type annotations * _get_nodes_needed_for_request_resources to use FrozenSet * comments * whitespace * [Placement Group] Fix resource index assignment between with bundle index and without bundle index pg (#17318) * [serve] Add Ray API stability annotations (#17295) * Support streaming output of runtime env setup to logger/driver (#17306) * [SGD] v2 prototype: ``WorkerGroup`` implementation (#17330) * wip * formatting * increase timeouts * address comments * comments * fix * address comments * Update python/ray/util/sgd/v2/worker_group.py Co-authored-by: Richard Liaw <[email protected]> * Update python/ray/util/sgd/v2/worker_group.py Co-authored-by: Richard Liaw <[email protected]> * address comments * formatting * fix * avoid race condition Co-authored-by: Richard Liaw <[email protected]> * [RLlib] Discussion 3001: Fix comment on internal state shape (must be [B x S=state dim]). (#17341) * [autoscaler] GCP TPU VM autoscaler (#17278) * [Rllib] set self._allow_unknown_config (#17335) Co-authored-by: Sven Mika <[email protected]> * [RLlib] Discussion 2294: Custom vector env example and fix. (#16083) * [docs] Link broken in Tune's page (#17394) (#17407) * [Serve] Fix response_model for class based view routes as well (#17376) * [serve] Fix single deployment nightly test (#17368) * [RLlib] SAC tuple observation space fix (#17356) * Support schema on read for csv/json (#17354) * [RLlib] New and changed version of parametric actions cartpole example + small suggested update in policy_client.py (#15664) * [gcs] Fix GCS related issues: ByteSizeLong and redis connection (#17373) * [runtime_env] Gracefully fail tasks when an environment fails to be set up (#17249) * [docs] update docs with pip requirements (#17317) * removed nodes_to_keep. cleanup * formatting * +comment * treat max_workers=0 as 0 workers (as opposed to unlimited) * fix wrong comment * warning for inconsistent config * terminate nodes with no matching node type right away * quotes * special handling for head node when enforcing max_workers per type. tests. cleanup * cleanup comments and prints * comments * cleanup. removed special handling of head node. * adding an eplicit non-None check in schedule_node_termination * raise the exception Co-authored-by: Ameer Haj Ali <[email protected]> Co-authored-by: Ameer Haj Ali <[email protected]> Co-authored-by: DK.Pino <[email protected]> Co-authored-by: Edward Oakes <[email protected]> Co-authored-by: Simon Mo <[email protected]> Co-authored-by: Amog Kamsetty <[email protected]> Co-authored-by: Richard Liaw <[email protected]> Co-authored-by: Sven Mika <[email protected]> Co-authored-by: Antoni Baum <[email protected]> Co-authored-by: Rohan138 <[email protected]> Co-authored-by: amavilla <[email protected]> Co-authored-by: Jiao <[email protected]> Co-authored-by: Julius Frost <[email protected]> Co-authored-by: Eric Liang <[email protected]> Co-authored-by: kk-55 <[email protected]> Co-authored-by: Yi Cheng <[email protected]> Co-authored-by: matthewdeng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
I forgot to update single deployment test after the ray remote function and api change. This is needs to be merged so single deployment benchmark is still running.
Checks
scripts/format.shto lint the changes in this PR.