Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix single deployment benchmark #17368

Merged
merged 4 commits into from
Jul 28, 2021
Merged

fix single deployment benchmark #17368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
15b2a49
fix single deployment
jiaodong Jul 27, 2021
f708882
change # connections to 10 for stable benchmark
jiaodong Jul 27, 2021
48938a5
remove 5s timeout
jiaodong Jul 27, 2021
d637883
nits
jiaodong Jul 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion release/serve_tests/workloads/serve_test_cluster_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

# Cluster setup configs
NUM_CPU_PER_NODE = 10
NUM_CONNECTIONS = 100
NUM_CONNECTIONS = 10


def setup_local_single_node_cluster(num_nodes):
Expand Down
1 change: 0 additions & 1 deletion release/serve_tests/workloads/serve_test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,6 @@ def run_one_wrk_trial(trial_length: str,
"-d",
trial_length,
"--latency",
"--timeout=5s",
f"http://{http_host}:{http_port}/{endpoint}",
],
stdout=PIPE,
Expand Down
4 changes: 2 additions & 2 deletions release/serve_tests/workloads/single_deployment_1k_noop_replica.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
from serve_test_cluster_utils import (
setup_local_single_node_cluster,
setup_anyscale_cluster,
warm_up_cluster,
warm_up_one_cluster,
NUM_CPU_PER_NODE,
NUM_CONNECTIONS,
)
Expand Down Expand Up @@ -115,7 +115,7 @@ def main(num_replicas: Optional[int], trial_length: Optional[str],
deploy_replicas(num_replicas, max_batch_size)

logger.info("Warming up cluster ....\n")
warm_up_cluster(10, http_host, http_port)
warm_up_one_cluster.remote(10, http_host, http_port, "echo")

logger.info(f"Starting wrk trial on all nodes for {trial_length} ....\n")
# For detailed discussion, see https://github.com/wg/wrk/issues/205
Expand Down