Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tune] let placement groups be cleaned up by reconciliation #18650

Closed
wants to merge 3 commits into from

Conversation

krfricke
Copy link
Contributor

Why are these changes needed?

Since we removed pending placement groups on return immediately, the trial executor staged new trial placement groups before removing them subsequently in the reconciliation process. Deferring removal until reconciliation will avoid overloading GCS with placement group requests.

cc @rkooo567

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@xwjiang2010
Copy link
Contributor

Should we add a test that captures GCS overloading regression?

@krfricke
Copy link
Contributor Author

Closed in favor of #18706

@krfricke krfricke closed this Sep 17, 2021
@krfricke krfricke deleted the tune/pg-recreation branch September 17, 2021 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants