[Placement Group] Fix placement group high cpu usage part 1 #18652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkooo567
commented
Sep 15, 2021
clay4megtr
reviewed
Sep 16, 2021
ericl
reviewed
Sep 16, 2021
ericl
added
the
@author-action-required
rkooo567
removed
the
@author-action-required
ericl
added
the
@author-action-required
fishbone
reviewed
Sep 21, 2021
fishbone
reviewed
Sep 21, 2021
| @@ -109,12 +123,12 @@ std::string FormatPlacementGroupResource(const std::string &original_resource_na | |||
|
|
|||
| bool IsBundleIndex(const std::string &resource, const PlacementGroupID &group_id, | |||
| const int bundle_index) { | |||
| return resource.find("_group_" + std::to_string(bundle_index) + "_" + group_id.Hex()) != | |||
| std::string::npos; | |||
| return resource.find(kGroupKeyword + std::to_string(bundle_index) + "_" + | |||
There was a problem hiding this comment.
I think std::to_string here will benefit from this (#18538)
Are you seeing anything different after that PR merged?
There was a problem hiding this comment.
It'll benefit small string if it's less than 22 chars.
fishbone
reviewed
Sep 21, 2021
fishbone
reviewed
Sep 21, 2021
|
I think overall it looks good. Some comments there. Please let me know if you have any concerns. |
rkooo567
removed
the
@author-action-required
ericl
added
the
@author-action-required
|
Tests / lint broken |
rkooo567
removed
the
@author-action-required
ericl
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Implement;
This also makes
GetBundleto return const which is a more ideal semantic.This makes many_ppo runs 6+ hours rather than 1 hour.
With this PR #18650, it should make many_ppo run for a day without an issue.
For more detail please check the related issue.
Related issue number
Part of #18651
With this PR and #18650, this should fix the P0 release blocker #18541. But we should also fix the fundamental issue (I marked it as P1, and I can work on it next sprint)
Checks
scripts/format.shto lint the changes in this PR.