[serve] Implement set_options #23265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edoakes
reviewed
Mar 17, 2022
edoakes
added
the
@author-action-required
Co-authored-by: Edward Oakes <[email protected]>
shrekris-anyscale
removed
the
@author-action-required
edoakes
approved these changes
Mar 17, 2022
simon-mo
reviewed
Mar 17, 2022
python/ray/serve/api.py
Outdated
Comment on lines
1308
to
1327
| self._config.num_replicas = validated._config.num_replicas | ||
| self._config.user_config = validated._config.user_config | ||
| self._config.max_concurrent_queries = validated._config.max_concurrent_queries | ||
| self._func_or_class = validated._func_or_class | ||
| self._name = validated._name | ||
| self._version = validated._version | ||
| self._prev_version = validated._prev_version | ||
| self._init_args = validated._init_args | ||
| self._init_kwargs = validated._init_kwargs | ||
| self._route_prefix = validated._route_prefix | ||
| self._ray_actor_options = validated._ray_actor_options | ||
| self._config.autoscaling_config = validated._config.autoscaling_config | ||
| self._config.graceful_shutdown_wait_loop_s = ( | ||
| validated._config.graceful_shutdown_wait_loop_s | ||
| ) | ||
| self._config.graceful_shutdown_timeout_s = ( | ||
| validated._config.graceful_shutdown_timeout_s | ||
| ) | ||
| self._config.health_check_period_s = validated._config.health_check_period_s | ||
| self._config.health_check_timeout_s = validated._config.health_check_timeout_s |
There was a problem hiding this comment.
just self._config = validated._config?
There was a problem hiding this comment.
Good idea– I changed it.
simon-mo
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
#23157 and #23232 introduce an
Applicationobject with an immutable deployment dictionary. This change introducesset_options(), a deployment method that mutates its attributes. This allows anApplication's deployments to be edited after initialization.Related issue number
N/A
Checks
scripts/format.shto lint the changes in this PR.test_api.py.