Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Train] Clean up ray.train package #25566

Merged
merged 9 commits into from
Jun 8, 2022
Merged

[Train] Clean up ray.train package #25566

merged 9 commits into from
Jun 8, 2022

Conversation

amogkam
Copy link
Contributor

@amogkam amogkam commented Jun 7, 2022 •
edited
Loading

Cleans up entire ray.train package. Enables annotation checking for ray.train. This PR does not do any deprecations yet.

  • Creates subpackages for torch, tensorflow, horovod
  • Moves implementation to an _internal subpackage
  • Separates out user facing components from internal only components

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@amogkam amogkam changed the title [Train] Clean up ray.train [Train] Clean up ray.train package Jun 7, 2022
@amogkam amogkam mentioned this pull request Jun 7, 2022
Merged
6 tasks
krfricke
krfricke approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Should we rename the train_loop_utils.py files just to train_loop.py?

@richardliaw richardliaw merged commit 80ae651 into ray-project:master Jun 8, 2022
sumanthratna pushed a commit to sumanthratna/ray that referenced this pull request Jun 8, 2022
@amogkam @sumanthratna
[Train] Clean up ray.train package (ray-project#25566)
486a610
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krfricke krfricke krfricke approved these changes

@Yard1 Yard1 Yard1 approved these changes

@richardliaw richardliaw Awaiting requested review from richardliaw

@xwjiang2010 xwjiang2010 Awaiting requested review from xwjiang2010

@matthewdeng matthewdeng Awaiting requested review from matthewdeng matthewdeng is a code owner

@maxpumperla maxpumperla Awaiting requested review from maxpumperla

Assignees

@ericl ericl

@matthewdeng matthewdeng

@richardliaw richardliaw

@Yard1 Yard1

@krfricke krfricke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@amogkam @Yard1 @krfricke @ericl @matthewdeng @richardliaw