Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Train] Clean up ray.train package #25566

Merged
merged 9 commits into from
Jun 8, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions .buildkite/pipeline.ml.yml
Original file line number Diff line number Diff line change
Expand Up @@ -319,12 +319,13 @@
- bazel test --config=ci $(./ci/run/bazel_export_options) --build_tests_only python/ray/util/horovod/...
- bazel test --config=ci $(./ci/run/bazel_export_options) --build_tests_only python/ray/util/ray_lightning/...

- label: ":octopus: Ludwig tests and examples. Python 3.7"
conditions: ["RAY_CI_TUNE_AFFECTED"]
commands:
- cleanup() { if [ "${BUILDKITE_PULL_REQUEST}" = "false" ]; then ./ci/build/upload_build_info.sh; fi }; trap cleanup EXIT
- PYTHON=3.7 INSTALL_LUDWIG=1 INSTALL_HOROVOD=1 ./ci/env/install-dependencies.sh
- bazel test --config=ci $(./ci/run/bazel_export_options) --build_tests_only python/ray/tests/ludwig/...
# TODO(amogkam): Re-enable Ludwig tests after Ludwig supports Ray 2.0
#- label: ":octopus: Ludwig tests and examples. Python 3.7"
# conditions: ["RAY_CI_TUNE_AFFECTED"]
# commands:
# - cleanup() { if [ "${BUILDKITE_PULL_REQUEST}" = "false" ]; then ./ci/build/upload_build_info.sh; fi }; trap cleanup EXIT
# - PYTHON=3.7 INSTALL_LUDWIG=1 INSTALL_HOROVOD=1 ./ci/env/install-dependencies.sh
# - bazel test --config=ci $(./ci/run/bazel_export_options) --build_tests_only python/ray/tests/ludwig/...

- label: ":tropical_fish: ML Libraries w/ Ray Client Examples (Python 3.7)."
conditions: ["RAY_CI_TUNE_AFFECTED"]
Expand Down
2 changes: 1 addition & 1 deletion ci/lint/check_api_annotations.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,8 @@ def verify(symbol, scanned, ok, output, prefix=None):

verify(ray.rllib, set(), ok, output)
verify(ray.air, set(), ok, output)
verify(ray.train, set(), ok, output)
# TODO(ekl) enable it for all modules.
# verify(ray.train, set(), ok, output)
# verify(ray.serve, set(), ok, output)
# verify(ray.tune, set(), ok, output)
# verify(ray, set(), ok, output)
Expand Down
26 changes: 0 additions & 26 deletions doc/source/train/api.rst
Original file line number Diff line number Diff line change
Expand Up @@ -109,32 +109,6 @@ TorchTensorboardProfilerCallback

.. autoclass:: ray.train.callbacks.TorchTensorboardProfilerCallback

ResultsPreprocessors
~~~~~~~~~~~~~~~~~~~~

.. _train-api-results-preprocessor:

ResultsPreprocessor
+++++++++++++++++++

.. autoclass:: ray.train.callbacks.results_preprocessors.ResultsPreprocessor
:members:

SequentialResultsPreprocessor
+++++++++++++++++++++++++++++++

.. autoclass:: ray.train.callbacks.results_preprocessors.SequentialResultsPreprocessor

IndexedResultsPreprocessor
+++++++++++++++++++++++++++++++

.. autoclass:: ray.train.callbacks.results_preprocessors.IndexedResultsPreprocessor

ExcludedKeysResultsPreprocessor
+++++++++++++++++++++++++++++++

.. autoclass:: ray.train.callbacks.results_preprocessors.ExcludedKeysResultsPreprocessor

Checkpointing
-------------

Expand Down
6 changes: 3 additions & 3 deletions python/ray/air/train/data_parallel_trainer.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@
from ray.air.checkpoint import Checkpoint
from ray.air.train.data_parallel_ingest import _DataParallelIngestSpec
from ray.train import BackendConfig, TrainingIterator
from ray.train.backend import BackendExecutor
from ray.train._checkpoint import TuneCheckpointManager
from ray.train.utils import construct_train_func
from ray.train._internal.backend_executor import BackendExecutor
from ray.train._internal.checkpoint import TuneCheckpointManager
from ray.train._internal.utils import construct_train_func
from ray.util.annotations import DeveloperAPI
from ray.util.ml_utils.checkpoint_manager import CheckpointStrategy, _TrackedCheckpoint

Expand Down
2 changes: 1 addition & 1 deletion python/ray/train/__init__.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from ray.train.backend import BackendConfig
from ray.train.callbacks import TrainingCallback
from ray.train.session import (
from ray.train.train_loop_utils import (
get_dataset_shard,
local_rank,
load_checkpoint,
Expand Down
Loading