[AIR/train] Use new Train API #25735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Yard1
requested review from
richardliaw,
krfricke,
xwjiang2010,
amogkam,
matthewdeng and
maxpumperla
as code owners
Yard1
removed
the
tests-ok
amogkam
approved these changes
Jul 7, 2022
| @@ -2,14 +2,14 @@ | |||
| from typing import Dict | |||
There was a problem hiding this comment.
+1 we should make sure to dedup and move over the AIR examples to train in a follow up
|
@amogkam it's ready to merge! |
7 tasks
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
Uses the new AIR Train API for examples and tests. The `Result` object gets a new attribute - `log_dir`, pointing to the Trial's `logdir` allowing users to access tensorboard logs and artifacts of other loggers. This PR only deals with "low hanging fruit" - tests that need substantial rewriting or Train user guide are not touched. Those will be updated in followup PRs. Tests and examples that concern deprecated features or which are duplicated in AIR have been removed or disabled. Requires ray-project#25943 to be merged in first Signed-off-by: Stefan van der Kleij <[email protected]>
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
This PR replaces legacy API calls to `train.` with AIR `session.` in Train code, examples and docs. Depends on ray-project#25735 Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Uses the new AIR Train API for examples and tests.
The
Resultobject gets a new attribute -log_dir, pointing to the Trial'slogdirallowing users to access tensorboard logs and artifacts of other loggers.This PR only deals with "low hanging fruit" - tests that need substantial rewriting or Train user guide are not touched. Those will be updated in followup PRs.
Tests and examples that concern deprecated features or which are duplicated in AIR have been removed or disabled.
Requires #25943 to be merged in first
Related issue number
Checks
scripts/format.shto lint the changes in this PR.