Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIR] Replace train. with session. #26303

Merged
merged 99 commits into from
Jul 7, 2022

Conversation

Yard1
Copy link
Member

@Yard1 Yard1 commented Jul 5, 2022

Why are these changes needed?

This PR replaces legacy API calls to train. with AIR session. in Train code, examples and docs.

Depends on #25735

Related issue number

Closes #26258
Closes #25143

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Contributor

@amogkam amogkam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please ping again when this is ready to merge

@Yard1
Copy link
Member Author

Yard1 commented Jul 7, 2022

@amogkam ready to merge!

@amogkam amogkam merged commit ea94cda into ray-project:master Jul 7, 2022
@Yard1 Yard1 deleted the replace_train_with_session branch July 7, 2022 23:58
Stefan-1313 pushed a commit to Stefan-1313/ray_mod that referenced this pull request Aug 18, 2022
This PR replaces legacy API calls to `train.` with AIR `session.` in Train code, examples and docs.

Depends on ray-project#25735

Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants