Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump gym dep to 0.24 #26190

Merged
merged 5 commits into from
Jul 22, 2022
Merged

Bump gym dep to 0.24 #26190

merged 5 commits into from
Jul 22, 2022

Conversation

smorad
Copy link
Contributor

@smorad smorad commented Jun 29, 2022

Why are these changes needed?

This enables the use of later version of gym with rllib

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@gjoliver
Copy link
Member

can you update DCO?
this is a new requirement for all commits going into Ray repo.
click the Details link will give you the steps.

@avnishn
Copy link
Member

avnishn commented Jul 20, 2022

@gjoliver dco will not be an enforced requirement for a few weeks

@avnishn avnishn self-requested a review July 20, 2022 21:47
@avnishn
Copy link
Member

avnishn commented Jul 22, 2022

release test failure related to #26579

@richardliaw richardliaw merged commit 259429b into ray-project:master Jul 22, 2022
@smorad smorad deleted the gym-24 branch July 25, 2022 10:04
Rohan138 pushed a commit to Rohan138/ray that referenced this pull request Jul 28, 2022
Co-authored-by: Steven Morad <[email protected]>
Co-authored-by: Avnish <[email protected]>
Co-authored-by: Avnish Narayan <[email protected]>
Signed-off-by: Rohan138 <[email protected]>
Stefan-1313 pushed a commit to Stefan-1313/ray_mod that referenced this pull request Aug 18, 2022
Co-authored-by: Steven Morad <[email protected]>
Co-authored-by: Avnish <[email protected]>
Co-authored-by: Avnish Narayan <[email protected]>
Signed-off-by: Stefan van der Kleij <[email protected]>
@smorad smorad mentioned this pull request Nov 26, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants