Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Actually bump gym dep #30673

Closed
wants to merge 1 commit into from
Closed

Conversation

smorad
Copy link
Contributor

@smorad smorad commented Nov 26, 2022

Why are these changes needed?

I previously made rllib work with gym==0.24.0 in #26190, bumping the gym version in requirements.txt. Unfortunately, it seems like the version is hardcoded in setup.py, which I missed. This commit should make pip install gym==0.24.0 ray[rllib] run without error.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Steven Morad <[email protected]>
@avnishn avnishn self-assigned this Nov 28, 2022
Copy link
Member

@avnishn avnishn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smorad there's a few other places in the library you'll need to update this version dependency.

@avnishn
Copy link
Member

avnishn commented Dec 7, 2022

closing in favor of @sven1977's gym pr #28369

@avnishn avnishn closed this Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants