-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rllib] Use compress observations where replay buffers and image obs are used in tuned examples #26735
[rllib] Use compress observations where replay buffers and image obs are used in tuned examples #26735
Conversation
… in tuned examples Signed-off-by: avnish <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit nit nit
can we write the comments more formally, like:
Compress observations to make sure the size of the ReplayBuffer fits most computers.
something like that? not really good at wording, but you get the idea.
thanks.
could I change "we should set compress_observations to True because few machines would be able to contain the replay buffers in memory otherwise" is that descriptive enough? |
Signed-off-by: Avnish <[email protected]>
I addressed the comments, but during today's experiments realized that only pong examples need obs compression so I turned off the compression in the non pong examples that I changed before. |
min_sample_timesteps_per_iteration: 25000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just needed a newline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is good trick.
@richardliaw please merge |
…are used in tuned examples (ray-project#26735) Signed-off-by: Rohan138 <[email protected]>
…are used in tuned examples (ray-project#26735) Signed-off-by: Stefan van der Kleij <[email protected]>
Many of our tuned examples using replay and atari wouldn't be able to run on clusters or single node machines because they'll oom without enabling this compression.
Signed-off-by: avnish [email protected]
Why are these changes needed?
Related issue number
Checks
scripts/format.sh
to lint the changes in this PR.