Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rllib] Use compress observations where replay buffers and image obs are used in tuned examples #26735

Merged
merged 2 commits into from
Jul 22, 2022
Merged

[rllib] Use compress observations where replay buffers and image obs are used in tuned examples #26735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c619b9
Use compress observations where replay buffers and image obs are used…
avnishn Jul 19, 2022
2f6fb63
Only Pong needs obs compression; update comment explaining compression
avnishn Jul 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rllib/tuned_examples/apex_dqn/atari-apex-dqn.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,4 @@ apex-breakoutnoframeskip-v4:
rollout_fragment_length: 20
train_batch_size: 512
target_network_update_freq: 50000
min_sample_timesteps_per_iteration: 25000
min_sample_timesteps_per_iteration: 25000
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just needed a newline

3 changes: 3 additions & 0 deletions rllib/tuned_examples/apex_dqn/pong-apex-dqn.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,8 @@ pong-apex:
replay_buffer_config:
type: MultiAgentPrioritizedReplayBuffer
capacity: 1000000
# we should set compress_observations to True because few machines
# would be able to contain the replay buffers in memory otherwise
compress_observations: True
gamma: 0.99
training_intensity: 16
3 changes: 3 additions & 0 deletions rllib/tuned_examples/dqn/pong-dqn.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,6 @@ pong-deterministic-dqn:
grayscale: True
zero_mean: False
dim: 42
# we should set compress_observations to True because few machines
# would be able to contain the replay buffers in memory otherwise
compress_observations: True
3 changes: 3 additions & 0 deletions rllib/tuned_examples/dqn/pong-rainbow.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,6 @@ pong-deterministic-rainbow:
grayscale: True
zero_mean: False
dim: 42
# we should set compress_observations to True because few machines
# would be able to contain the replay buffers in memory otherwise
compress_observations: True