-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[P0][AIR] Fix train to serve notebooks #26821
[P0][AIR] Fix train to serve notebooks #26821
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Serve part LGTM
Co-authored-by: Simon Mo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. We should use the new Concatenator preprocessor instead of implementing a custom one, but we can do this in a follow up PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stamp
seems this breaks windows://python/ray/serve:test_air_integrations not sure how important that one is. @jiaodong to triage. |
Ah my bad. I will fix it asap. |
Error is windows only that suggests on windows, unpacking TensorArray changes underlying data type from
|
n previous implementation #26821 we have windows failure suggesting we behave differently on windows regarding datatype conversion. In our https://sourcegraph.com/github.com/ray-project/ray/-/blob/python/ray/data/tests/test_dataset.py?L577 regarding use of TensorArray we seem to rely on pd'sassert_frame_equal rather than manually comparing frames. This PR adds a quick conditional on windows only to ignore dtype for now.
Co-authored-by: Simon Mo <[email protected]> Signed-off-by: Rohan138 <[email protected]>
…t#26889 n previous implementation ray-project#26821 we have windows failure suggesting we behave differently on windows regarding datatype conversion. In our https://sourcegraph.com/github.com/ray-project/ray/-/blob/python/ray/data/tests/test_dataset.py?L577 regarding use of TensorArray we seem to rely on pd'sassert_frame_equal rather than manually comparing frames. This PR adds a quick conditional on windows only to ignore dtype for now. Signed-off-by: Rohan138 <[email protected]>
Co-authored-by: Simon Mo <[email protected]> Signed-off-by: Stefan van der Kleij <[email protected]>
…t#26889 n previous implementation ray-project#26821 we have windows failure suggesting we behave differently on windows regarding datatype conversion. In our https://sourcegraph.com/github.com/ray-project/ray/-/blob/python/ray/data/tests/test_dataset.py?L577 regarding use of TensorArray we seem to rely on pd'sassert_frame_equal rather than manually comparing frames. This PR adds a quick conditional on windows only to ignore dtype for now. Signed-off-by: Stefan van der Kleij <[email protected]>
Why are these changes needed?
This is the last PR needed before we have ALL AIR notebooks fixed and enabled on CI for Ray 2.0
Notable changes
Use
TensorArray
for incremental learning's imagesConditional on dropped column for tabular train to serve
Since AIR's
BatchPredictor
returns at mostpd.DataFrame({col: TensorArray})
with no nesting, simply iterate all columns and callto_numpy
forTensorArray
andTensorArrayElement
.Related issue number
Closes #26410
Checks
scripts/format.sh
to lint the changes in this PR.