[AIR][Serve] Add windows check for pd.DataFrame comparison #26889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardliaw
reviewed
Jul 22, 2022
| @@ -90,8 +91,13 @@ def test_dataframe_with_tensorarray(self): | |||
|
|
|||
| unpacked_list = BatchingManager.split_dataframe(batched_df, 1) | |||
| assert len(unpacked_list) == 1 | |||
| assert unpacked_list[0]["a"].equals(split_df["a"]) | |||
| assert unpacked_list[0]["b"].equals(split_df["b"]) | |||
| # On windows, conversion dtype is not preserved. | |||
There was a problem hiding this comment.
cc: @clarkzinzow for awareness .. not sure if its related to TensorArray, but in the worst case this means AIR could mess up user's tensor dtype among full / half / mixed precision training =.=
scv119
approved these changes
Jul 22, 2022
Rohan138
pushed a commit
to Rohan138/ray
that referenced
this pull request
Jul 28, 2022
…t#26889 n previous implementation ray-project#26821 we have windows failure suggesting we behave differently on windows regarding datatype conversion. In our https://sourcegraph.com/github.com/ray-project/ray/-/blob/python/ray/data/tests/test_dataset.py?L577 regarding use of TensorArray we seem to rely on pd'sassert_frame_equal rather than manually comparing frames. This PR adds a quick conditional on windows only to ignore dtype for now. Signed-off-by: Rohan138 <[email protected]>
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
…t#26889 n previous implementation ray-project#26821 we have windows failure suggesting we behave differently on windows regarding datatype conversion. In our https://sourcegraph.com/github.com/ray-project/ray/-/blob/python/ray/data/tests/test_dataset.py?L577 regarding use of TensorArray we seem to rely on pd'sassert_frame_equal rather than manually comparing frames. This PR adds a quick conditional on windows only to ignore dtype for now. Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
In previous implementation #26821 we have windows failure suggesting we behave differently on windows regarding datatype conversion.
In our https://sourcegraph.com/github.com/ray-project/ray/-/blob/python/ray/data/tests/test_dataset.py?L577 regarding use of TensorArray we seem to rely on pd's
assert_frame_equalrather than manually comparing frames.This PR adds a quick conditional on windows only to ignore dtype for now.
Related issue number
Checks
scripts/format.shto lint the changes in this PR.