Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[xgboost/release/2.0.0] Fix XGBoost benchmark args #27158

Merged
merged 1 commit into from
Jul 28, 2022
Merged

[xgboost/release/2.0.0] Fix XGBoost benchmark args #27158

merged 1 commit into from
Jul 28, 2022

Conversation

krfricke
Copy link
Contributor

@krfricke krfricke commented Jul 28, 2022 •
edited
Loading

Why are these changes needed?

Cherry-picked #27146 for the release branch and for testing

Related issue number

Closes #27185

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@krfricke krfricke requested a review from scv119 July 28, 2022 07:32
@krfricke
Copy link
Contributor Author

Benchmark passes with this pick: https://buildkite.com/ray-project/release-tests-pr/builds/11606

@krfricke krfricke changed the title [xgboost/release] Fix XGBoost benchmark args [xgboost/release/2.0.0] Fix XGBoost benchmark args Jul 28, 2022
@krfricke krfricke mentioned this pull request Jul 28, 2022
Closed
@matthewdeng matthewdeng merged commit 24ed249 into ray-project:releases/2.0.0 Jul 28, 2022
@krfricke krfricke deleted the 2.0.0/pick/xgboost-benchmark-args branch September 22, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewdeng matthewdeng matthewdeng approved these changes

@scv119 scv119 Awaiting requested review from scv119

@richardliaw richardliaw Awaiting requested review from richardliaw

Assignees

@scv119 scv119

@richardliaw richardliaw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@krfricke @matthewdeng @scv119 @richardliaw