Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[air] fix xgboost_benchmark script by passing in args #27146

Merged
merged 1 commit into from
Jul 28, 2022
Merged

[air] fix xgboost_benchmark script by passing in args #27146

merged 1 commit into from
Jul 28, 2022

Conversation

matthewdeng
Copy link
Contributor

Signed-off-by: Matthew Deng [email protected]

Why are these changes needed?

This test was updated in #27023, and started failing with:

  File "xgboost_benchmark.py", line 144, in <module>
    main(args)
  File "xgboost_benchmark.py", line 113, in main
    training_time = run_xgboost_training(data_path, num_workers)
  File "xgboost_benchmark.py", line 61, in wrapper
    p = MyProcess(target=f, *args, **kwargs)
  File "xgboost_benchmark.py", line 43, in __init__
    super(MyProcess, self).__init__(*args, **kwargs)
TypeError: __init__() got multiple values for argument 'target'

This is because BaseProcess is expecting to take in function args and kwargs as named arguments.

Verification: https://console.anyscale-staging.com/o/anyscale-internal/projects/prj_mWECugke9RzMh79BZQqeykjN/clusters/ses_AqZgwEVpXMXnbjjTxaQPCXha

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

xwjiang2010
xwjiang2010 approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@xwjiang2010 xwjiang2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks Matt!

@richardliaw richardliaw merged commit 0319dcd into ray-project:master Jul 28, 2022
@krfricke krfricke mentioned this pull request Jul 28, 2022
Closed
7 tasks
krfricke pushed a commit to krfricke/ray that referenced this pull request Jul 28, 2022
@matthewdeng
[air] fix xgboost_benchmark script by passing in args (ray-project#27146
0fa2e1b 
)
@krfricke krfricke mentioned this pull request Jul 28, 2022
Merged
7 tasks
krfricke pushed a commit to krfricke/ray that referenced this pull request Jul 28, 2022
Revert "[air] fix xgboost_benchmark script by passing in args (ray-pr…
8a689b4 
…oject#27146)"

This reverts commit 0fa2e1b.
matthewdeng added a commit that referenced this pull request Jul 28, 2022
@krfricke @matthewdeng
[air] fix xgboost_benchmark script by passing in args (#27146) (#27158)
24ed249 
Co-authored-by: matthewdeng <[email protected]>
krfricke pushed a commit to krfricke/ray that referenced this pull request Jul 28, 2022
Revert "[air] fix xgboost_benchmark script by passing in args (ray-pr…
638c7ae 
…oject#27146)"

This reverts commit 0fa2e1b.
krfricke pushed a commit to krfricke/ray that referenced this pull request Jul 28, 2022
Revert "[air] fix xgboost_benchmark script by passing in args (ray-pr…
1991916 
…oject#27146)"

This reverts commit 0fa2e1b.
krfricke pushed a commit to krfricke/ray that referenced this pull request Jul 28, 2022
Revert "[air] fix xgboost_benchmark script by passing in args (ray-pr…
51d91eb 
…oject#27146)"

This reverts commit 0fa2e1b.
scv119 pushed a commit that referenced this pull request Aug 2, 2022
@krfricke @matthewdeng
[release/tune/2.0.0] Fix k8s release test + node-to-node syncing (#27365
0d4d4e1 
)

* [air] fix xgboost_benchmark script by passing in args (#27146)

* [tune/docs] Update custom syncer example (#27252)

There is a small bug in the docs example for custom command based syncers. This PR fixes them and adds a test to test these changes.

Signed-off-by: Kai Fricke <[email protected]>

* [tune/release] Do not use spot instances in k8s tests (#27250)

Spot instances are not being booted up, so let's go without them.

Signed-off-by: Kai Fricke <[email protected]>

Co-authored-by: matthewdeng <[email protected]>
Stefan-1313 pushed a commit to Stefan-1313/ray_mod that referenced this pull request Aug 18, 2022
@matthewdeng
[air] fix xgboost_benchmark script by passing in args (ray-project#27146
95d6e64 
)

Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xwjiang2010 xwjiang2010 xwjiang2010 approved these changes

@scv119 scv119 Awaiting requested review from scv119

Assignees

@richardliaw richardliaw

@amogkam amogkam

@xwjiang2010 xwjiang2010

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@matthewdeng @xwjiang2010 @scv119 @richardliaw @amogkam