Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tune/release] Do not use spot instances in k8s tests #27250

Merged
merged 5 commits into from
Aug 2, 2022
Merged

[tune/release] Do not use spot instances in k8s tests #27250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
160cb99
[tune/release] Do not use spot instances in k8s tests
Jul 29, 2022
a3b42b5
Fix sync scheduling
Aug 1, 2022
f89f631
Use old API
Aug 1, 2022
7d7e99f
Merge branch 'master' into tune/release/k8s
Aug 1, 2022
11b371f
default scheduling strategy
Aug 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion python/ray/tune/utils/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,9 @@ def _get_checkpoint_from_remote_node(
)
return None
fut = _serialize_checkpoint.options(
resources={f"node:{node_ip}": 0.01}, num_cpus=0
resources={f"node:{node_ip}": 0.01},
num_cpus=0,
scheduling_strategy="DEFAULT",
).remote(checkpoint_path)
try:
checkpoint_data = ray.get(fut, timeout=timeout)
Expand Down
2 changes: 1 addition & 1 deletion release/tune_tests/cloud_tests/tpl_gcp_k8s_4x8.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ worker_node_types:
instance_type: n2-standard-8
min_workers: 3
max_workers: 3
use_spot: true
use_spot: false
4 changes: 2 additions & 2 deletions release/tune_tests/cloud_tests/workloads/run_cloud_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,11 +99,11 @@ def __init__(

@property
def hostname(self):
return self.last_result["hostname"]
return self.last_result.get("hostname")

@property
def node_ip(self):
return self.last_result["node_ip"]
return self.last_result.get("node_ip")

@property
def dirname(self):
Expand Down