Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tune/release] Do not use spot instances in k8s tests #27250

Merged
merged 5 commits into from
Aug 2, 2022

Conversation

krfricke
Copy link
Contributor

Signed-off-by: Kai Fricke [email protected]

Why are these changes needed?

Spot instances are not being booted up, so let's go without them.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@krfricke krfricke merged commit 149c031 into ray-project:master Aug 2, 2022
@krfricke krfricke deleted the tune/release/k8s branch August 2, 2022 10:30
krfricke added a commit to krfricke/ray that referenced this pull request Aug 2, 2022
)

Spot instances are not being booted up, so let's go without them.

Signed-off-by: Kai Fricke <[email protected]>
scv119 pushed a commit that referenced this pull request Aug 2, 2022
)

* [air] fix xgboost_benchmark script by passing in args (#27146)

* [tune/docs] Update custom syncer example (#27252)

There is a small bug in the docs example for custom command based syncers. This PR fixes them and adds a test to test these changes.

Signed-off-by: Kai Fricke <[email protected]>

* [tune/release] Do not use spot instances in k8s tests (#27250)

Spot instances are not being booted up, so let's go without them.

Signed-off-by: Kai Fricke <[email protected]>

Co-authored-by: matthewdeng <[email protected]>
Stefan-1313 pushed a commit to Stefan-1313/ray_mod that referenced this pull request Aug 18, 2022
)

Spot instances are not being booted up, so let's go without them.

Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants