Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Atari gym environments now require ale-py #28703

Merged
merged 1 commit into from
Sep 22, 2022
Merged

[RLlib] Atari gym environments now require ale-py #28703

merged 1 commit into from
Sep 22, 2022

Conversation

ArturNiederfahrenhorst
Copy link
Contributor

@ArturNiederfahrenhorst ArturNiederfahrenhorst commented Sep 22, 2022 •
edited
Loading

Signed-off-by: Artur Niederfahrenhorst [email protected]

Why are these changes needed?

Atari Gym environments are failing our CI. This PR adds the two missing dependencies.

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@ArturNiederfahrenhorst
initial
1b7f0bb 
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
@ArturNiederfahrenhorst ArturNiederfahrenhorst mentioned this pull request Sep 22, 2022
Closed
krfricke
krfricke approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sven1977 sven1977 merged commit 42874e1 into ray-project:master Sep 22, 2022
@ArturNiederfahrenhorst ArturNiederfahrenhorst mentioned this pull request Sep 26, 2022
Closed
This was referenced Sep 26, 2022
Closed
Closed
Closed
Closed
Closed
matthewdeng pushed a commit that referenced this pull request Sep 26, 2022
@ArturNiederfahrenhorst @matthewdeng
[RLlib] Atari gym environments now require ale-py. (#28703)
9aca1c2
@ArturNiederfahrenhorst ArturNiederfahrenhorst mentioned this pull request Sep 29, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krfricke krfricke krfricke approved these changes

Assignees

@sven1977 sven1977

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArturNiederfahrenhorst @krfricke @sven1977