[RLlib] Pin ALE-py In Rllib Requirements And Other Release Test Fixes #28913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
|
release tests running here: https://buildkite.com/ray-project/release-tests-pr/builds/16786 |
avnishn
approved these changes
Sep 29, 2022
Signed-off-by: Avnish <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Avnish <[email protected]>
avnishn
force-pushed
the
gym_atari_to_rllib_reqs
branch
from
dadf794
to
1af8cb2
Compare
|
new release tests: https://buildkite.com/ray-project/release-tests-pr/builds/16830 |
Signed-off-by: Avnish <[email protected]>
Signed-off-by: Avnish <[email protected]>
Signed-off-by: Avnish <[email protected]>
|
https://buildkite.com/ray-project/release-tests-pr/builds/16853 just need to check to see if these ^ tests get kicked off and if they do then this is ready to merge |
avnishn
changed the title
avnishn
changed the title
|
tests were able to be kicked off
|
gjoliver
approved these changes
Sep 30, 2022
avnishn
added a commit
to avnishn/ray
that referenced
this pull request
Sep 30, 2022
…ray-project#28913) * initial Signed-off-by: Artur Niederfahrenhorst <[email protected]> * remove pin from app config Signed-off-by: Artur Niederfahrenhorst <[email protected]> * wip Signed-off-by: Artur Niederfahrenhorst <[email protected]> * app config needs pins to work right away Signed-off-by: Artur Niederfahrenhorst <[email protected]> * wip Signed-off-by: Artur Niederfahrenhorst <[email protected]> * wip Signed-off-by: Artur Niederfahrenhorst <[email protected]> * Fix removed statements Signed-off-by: Avnish <[email protected]> * extend comment to re-trigger release tests Signed-off-by: Artur Niederfahrenhorst <[email protected]> * Downgrade ale to 0.7.5 and remove gym deps from python/requirements.txt Signed-off-by: Avnish <[email protected]> * Change min_iter_time_s to min_iter_time_per_iteration Signed-off-by: Avnish <[email protected]> * ale-py 0.7.2 is not supported by python 3.6 but 0.7.1 is Signed-off-by: Avnish <[email protected]> * Fix more hard deprecated config names Signed-off-by: Avnish <[email protected]> Signed-off-by: Artur Niederfahrenhorst <[email protected]> Signed-off-by: Avnish <[email protected]> Co-authored-by: Avnish <[email protected]>
7 tasks
This was referenced Oct 3, 2022
7 tasks
matthewdeng
pushed a commit
that referenced
this pull request
Oct 3, 2022
…#28913) Signed-off-by: Artur Niederfahrenhorst <[email protected]> Signed-off-by: Avnish <[email protected]> Co-authored-by: Avnish <[email protected]>
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
…ray-project#28913) * initial Signed-off-by: Artur Niederfahrenhorst <[email protected]> * remove pin from app config Signed-off-by: Artur Niederfahrenhorst <[email protected]> * wip Signed-off-by: Artur Niederfahrenhorst <[email protected]> * app config needs pins to work right away Signed-off-by: Artur Niederfahrenhorst <[email protected]> * wip Signed-off-by: Artur Niederfahrenhorst <[email protected]> * wip Signed-off-by: Artur Niederfahrenhorst <[email protected]> * Fix removed statements Signed-off-by: Avnish <[email protected]> * extend comment to re-trigger release tests Signed-off-by: Artur Niederfahrenhorst <[email protected]> * Downgrade ale to 0.7.5 and remove gym deps from python/requirements.txt Signed-off-by: Avnish <[email protected]> * Change min_iter_time_s to min_iter_time_per_iteration Signed-off-by: Avnish <[email protected]> * ale-py 0.7.2 is not supported by python 3.6 but 0.7.1 is Signed-off-by: Avnish <[email protected]> * Fix more hard deprecated config names Signed-off-by: Avnish <[email protected]> Signed-off-by: Artur Niederfahrenhorst <[email protected]> Signed-off-by: Avnish <[email protected]> Co-authored-by: Avnish <[email protected]> Signed-off-by: Weichen Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artur Niederfahrenhorst [email protected]
Why are these changes needed?
The following issue persists in our RLlib release tests:
The initial fix is overwritten when install the requirements_rllib.txt, since Python versions >=3.7 will reinstall gym instead of gym[atari].
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.