-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RLlib] Pin ALE-py In Rllib Requirements And Other Release Test Fixes #28993
[RLlib] Pin ALE-py In Rllib Requirements And Other Release Test Fixes #28993
Conversation
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Avnish <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Avnish <[email protected]>
Signed-off-by: Avnish <[email protected]>
Signed-off-by: Avnish <[email protected]>
Signed-off-by: Avnish <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
I have a feeling gym shouldn't need to be in the base requirements.txt |
I agree. But for that we would need to move the offending tests, since we can't test integration without gym. So this should happen in the long term. This fix is merely a reference for the 2.0.1 release and maybe the short-term fix we can do for 2.1 which will be cut soon, |
…#28993) Signed-off-by: Artur Niederfahrenhorst <[email protected]> Signed-off-by: Avnish <[email protected]> Co-authored-by: Avnish <[email protected]>
…ray-project#28993) * initial Signed-off-by: Artur Niederfahrenhorst <[email protected]> * remove pin from app config Signed-off-by: Artur Niederfahrenhorst <[email protected]> * wip Signed-off-by: Artur Niederfahrenhorst <[email protected]> * app config needs pins to work right away Signed-off-by: Artur Niederfahrenhorst <[email protected]> * wip Signed-off-by: Artur Niederfahrenhorst <[email protected]> * wip Signed-off-by: Artur Niederfahrenhorst <[email protected]> * Fix removed statements Signed-off-by: Avnish <[email protected]> * extend comment to re-trigger release tests Signed-off-by: Artur Niederfahrenhorst <[email protected]> * Downgrade ale to 0.7.5 and remove gym deps from python/requirements.txt Signed-off-by: Avnish <[email protected]> * Change min_iter_time_s to min_iter_time_per_iteration Signed-off-by: Avnish <[email protected]> * ale-py 0.7.2 is not supported by python 3.6 but 0.7.1 is Signed-off-by: Avnish <[email protected]> * Fix more hard deprecated config names Signed-off-by: Avnish <[email protected]> * add back gym requirements to general requirements for integration tests Signed-off-by: Artur Niederfahrenhorst <[email protected]> Signed-off-by: Artur Niederfahrenhorst <[email protected]> Signed-off-by: Avnish <[email protected]> Co-authored-by: Avnish <[email protected]> Signed-off-by: Weichen Xu <[email protected]>
Why are these changes needed?
#28913 was merged but introduces another error: RLlib's Integration tests require gym.
Screenshot from the CI tests from that PR:
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.