Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Pin ALE-py In Rllib Requirements And Other Release Test Fixes #28993

Merged

Conversation

ArturNiederfahrenhorst
Copy link
Contributor

@ArturNiederfahrenhorst ArturNiederfahrenhorst commented Oct 3, 2022

Why are these changes needed?

#28913 was merged but introduces another error: RLlib's Integration tests require gym.
Screenshot from the CI tests from that PR:
Screenshot 2022-10-03 at 14 43 47

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
@gjoliver
Copy link
Member

gjoliver commented Oct 3, 2022

I have a feeling gym shouldn't need to be in the base requirements.txt
if any integration needs gym, it should probably install the ml/rl requirements?

@ArturNiederfahrenhorst
Copy link
Contributor Author

I have a feeling gym shouldn't need to be in the base requirements.txt if any integration needs gym, it should probably install the ml/rl requirements?

I agree. But for that we would need to move the offending tests, since we can't test integration without gym. So this should happen in the long term. This fix is merely a reference for the 2.0.1 release and maybe the short-term fix we can do for 2.1 which will be cut soon,

@gjoliver gjoliver merged commit f5f4073 into ray-project:master Oct 3, 2022
matthewdeng pushed a commit that referenced this pull request Oct 3, 2022
…#28993)

Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Avnish <[email protected]>
Co-authored-by: Avnish <[email protected]>
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
…ray-project#28993)

* initial

Signed-off-by: Artur Niederfahrenhorst <[email protected]>

* remove pin from app config

Signed-off-by: Artur Niederfahrenhorst <[email protected]>

* wip

Signed-off-by: Artur Niederfahrenhorst <[email protected]>

* app config needs pins to work right away

Signed-off-by: Artur Niederfahrenhorst <[email protected]>

* wip

Signed-off-by: Artur Niederfahrenhorst <[email protected]>

* wip

Signed-off-by: Artur Niederfahrenhorst <[email protected]>

* Fix removed statements

Signed-off-by: Avnish <[email protected]>

* extend comment to re-trigger release tests

Signed-off-by: Artur Niederfahrenhorst <[email protected]>

* Downgrade ale to 0.7.5 and remove gym deps from python/requirements.txt

Signed-off-by: Avnish <[email protected]>

* Change min_iter_time_s to min_iter_time_per_iteration

Signed-off-by: Avnish <[email protected]>

* ale-py 0.7.2 is not supported by python 3.6 but 0.7.1 is

Signed-off-by: Avnish <[email protected]>

* Fix more hard deprecated config names

Signed-off-by: Avnish <[email protected]>

* add back gym requirements to general requirements for integration tests

Signed-off-by: Artur Niederfahrenhorst <[email protected]>

Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Avnish <[email protected]>
Co-authored-by: Avnish <[email protected]>
Signed-off-by: Weichen Xu <[email protected]>
@ArturNiederfahrenhorst ArturNiederfahrenhorst deleted the gym_atari_to_rllib_reqs branch January 5, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants