[core] Mark run_function_on_all_workers as deprecated until we get rid of this.
#29062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yi Cheng <[email protected]>
|
do we know who is using it? |
scv119
approved these changes
Oct 4, 2022
scv119
reviewed
Oct 4, 2022
| @@ -683,6 +683,7 @@ def get_objects(self, object_refs: list, timeout: Optional[float] = None): | |||
| debugger_breakpoint, | |||
| ) | |||
|
|
|||
| @Deprecated | |||
There was a problem hiding this comment.
can we add some comments explain why it's deprecated? (as what you put in the PR summary)
|
@scv119 as far as I know, no one is using that. Modin has moved away from using this. |
Signed-off-by: Yi Cheng <[email protected]>
|
Does it make sense to deprecate it when this was never public APi? |
I think this is just to double warn the people who want to go to the dangerous zones not to do this. |
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
…rid of this. (ray-project#29062) run_function_on_all_workers has a lot of issues: no guarantee that the function run before the remote function run. pubsub signal might be lost in some failure cases. We can't delete it for now because the working dir init depends on this. So mark it as deprecated to warn people who uses this and delete it once we fix the working dir. Signed-off-by: Weichen Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yi Cheng [email protected]
Why are these changes needed?
run_function_on_all_workershas a lot of issues:We can't delete it for now because the working dir init depends on this. So mark it as deprecated to warn people who uses this and delete it once we fix the working dir.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.