[RLlib] Change Waterworld v3 to v4 #31820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArturNiederfahrenhorst
requested review from
gjoliver,
avnishn,
smorad and
maxpumperla
as code owners
ArturNiederfahrenhorst
requested review from
kouroshHakha and
krfricke
as code owners
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
ArturNiederfahrenhorst
force-pushed
the
fixwaterworldv3v4
branch
from
af59805
to
a4a7b73
Compare
sven1977
approved these changes
Jan 31, 2023
There was a problem hiding this comment.
LGTM. Thanks for the fix and for reinstating this test case @ArturNiederfahrenhorst !
clarng
pushed a commit
to clarng/ray
that referenced
this pull request
Jan 31, 2023
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
…e w/ pettingzoo. (ray-project#31820) Signed-off-by: Edward Oakes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artur Niederfahrenhorst [email protected]
Why are these changes needed?
Waterworld v3 was outdated and now throws an error. According to pettingzoo this was simply a refactor and they don't mentioned any changes to the env dynamics.
Related issue number
#31786
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.