Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Fix waterworld example and test #32117

Merged
merged 5 commits into from
Jan 31, 2023

Conversation

ArturNiederfahrenhorst
Copy link
Contributor

Signed-off-by: Artur Niederfahrenhorst [email protected]

Why are these changes needed?

Screenshot 2023-01-31 at 10 38 45

@ArturNiederfahrenhorst
Copy link
Contributor Author

ArturNiederfahrenhorst commented Jan 31, 2023

#31820 induces a broken CI test @gjoliver

Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
@ArturNiederfahrenhorst ArturNiederfahrenhorst changed the title [RLlib] Remove empty parser.add_argument() in waterworld example [RLlib] Fix waterworld example and test Jan 31, 2023
Copy link
Member

@gjoliver gjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix forward!

@gjoliver gjoliver merged commit 12ff13d into ray-project:master Jan 31, 2023
edoakes pushed a commit to edoakes/ray that referenced this pull request Mar 22, 2023
* Remove empty parser.add_argument() in test file
* remove --framework=torch
* fix BUILD
* use training_iteration as stopping cirterion

Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants