-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Serve][Doc] Update metrics & log doc #34222
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sihanwang41
force-pushed
the
monitoring_doc
branch
from
April 10, 2023 23:16
a3e0d68
to
14f1c46
Compare
Signed-off-by: Sihan Wang <[email protected]>
sihanwang41
force-pushed
the
monitoring_doc
branch
from
April 11, 2023 15:28
14f1c46
to
f784cb2
Compare
sihanwang41
requested review from
edoakes,
shrekris-anyscale,
zcin,
architkulkarni and
a team
as code owners
April 11, 2023 15:30
edoakes
approved these changes
Apr 11, 2023
angelinalg
reviewed
Apr 11, 2023
angelinalg
approved these changes
Apr 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: angelinalg <[email protected]> Signed-off-by: Sihan Wang <[email protected]>
test failures are not related. |
8 tasks
sihanwang41
added a commit
to sihanwang41/ray
that referenced
this pull request
Apr 14, 2023
Update the logging & metrics for the 2.4. change. Co-authored-by: angelinalg <[email protected]>
jjyao
pushed a commit
that referenced
this pull request
Apr 17, 2023
Update the logging & metrics for the 2.4. change. Co-authored-by: angelinalg <[email protected]>
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
Update the logging & metrics for the 2.4. change. Co-authored-by: angelinalg <[email protected]> Signed-off-by: elliottower <[email protected]>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
Update the logging & metrics for the 2.4. change. Co-authored-by: angelinalg <[email protected]> Signed-off-by: Jack He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Update the logging & metrics for the 2.4. change.
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.