Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CherryPick][Serve][Doc] Update metrics & log doc (#34222) #34326

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

sihanwang41
Copy link
Contributor

Update the logging & metrics for the 2.4. change.

Why are these changes needed?

cherrypick: #34222

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Update the logging & metrics for the 2.4. change.

Co-authored-by: angelinalg <[email protected]>
@akshay-anyscale
Copy link
Contributor

Do we also need to update list of metrics here - https://docs.ray.io/en/latest/serve/production-guide/monitoring.html#built-in-ray-serve-metrics

@sihanwang41
Copy link
Contributor Author

Do we also need to update list of metrics here - https://docs.ray.io/en/latest/serve/production-guide/monitoring.html#built-in-ray-serve-metrics

You are checking the 2.3.1, it is already updated in the 2.4.0 doc. https://anyscale-ray--34326.com.readthedocs.build/en/34326/serve/production-guide/monitoring.html

@sihanwang41
Copy link
Contributor Author

sihanwang41 commented Apr 14, 2023

tests failures are not related.

@sihanwang41
Copy link
Contributor Author

ping @zhe-thoughts ^^

@jjyao
Copy link
Collaborator

jjyao commented Apr 14, 2023

I'll merge after releasing to pypi

@jjyao jjyao merged commit d2e31fa into ray-project:releases/2.4.0 Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants