[ Core ]Fix bug for set gcs port environment variable #34367
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XiaodongLv
force-pushed
the
Fix_env_GCS_PORT_ENVIRONMENT_VARIABLE_to_support_change_port_for_starting_ray
branch
from
48ed97e
to
21ba161
Compare
Signed-off-by: XiaodongLv <[email protected]>
XiaodongLv
force-pushed
the
Fix_env_GCS_PORT_ENVIRONMENT_VARIABLE_to_support_change_port_for_starting_ray
branch
from
21ba161
to
508efed
Compare
Signed-off-by: XiaodongLv <[email protected]>
Signed-off-by: XiaodongLv <[email protected]>
…env_GCS_PORT_ENVIRONMENT_VARIABLE_to_support_change_port_for_starting_ray
Signed-off-by: XiaodongLv <[email protected]>
jovany-wang
reviewed
Apr 14, 2023
python/ray/tests/BUILD
Outdated
| @@ -304,6 +304,7 @@ py_test_module_list( | |||
| "test_usage_stats.py", | |||
| "test_placement_group_3.py", | |||
| "test_placement_group_5.py", | |||
| "test_env.py", | |||
There was a problem hiding this comment.
Suggested change
| "test_env.py", | |
| "test_set_gcs_server_port.py", |
There was a problem hiding this comment.
I have changed it.
Signed-off-by: XiaodongLv <[email protected]>
jjyao
reviewed
Apr 14, 2023
python/ray/_private/node.py
Outdated
| @@ -270,7 +270,16 @@ def __init__( | |||
|
|
|||
| # Pick a GCS server port. | |||
| if head: | |||
| gcs_server_port = os.getenv(ray_constants.GCS_PORT_ENVIRONMENT_VARIABLE) | |||
| gcs_server_port_environment = os.getenv( | |||
There was a problem hiding this comment.
ray_constants.py has a helper function called env_integer(), lets use that.
There was a problem hiding this comment.
Thankyou, I will change it.
There was a problem hiding this comment.
@jjyao I have completed it
Signed-off-by: XiaodongLv <[email protected]>
rkooo567
reviewed
Apr 17, 2023
| @@ -270,7 +270,11 @@ def __init__( | |||
|
|
|||
| # Pick a GCS server port. | |||
| if head: | |||
| gcs_server_port = os.getenv(ray_constants.GCS_PORT_ENVIRONMENT_VARIABLE) | |||
| from ray.autoscaler._private.constants import env_integer | |||
There was a problem hiding this comment.
can you use the method under ray._private.ray_constants, not the autoscaler package? (not sure why it has the same method there)
| ray.shutdown() | ||
|
|
||
|
|
||
| # If RAY_GCS_SERVER_PORT is set as string, it will be ignored so that |
There was a problem hiding this comment.
The comment and test doesn't seem to match?
8 tasks
|
Hmm it seems duplicate of #34482 (comment). cc @scv119 to confirm |
|
Duplicate to #34482 . closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
When RAY_GCS_SERVER_PORT is set, ray.init() is executed locally will failed.
TypeError: '>' not supported between instances of 'str' and 'int'.
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.