Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] convert gcs port read from env variable from str to int #34482

Merged
merged 3 commits into from
Apr 17, 2023
Merged

[Core] convert gcs port read from env variable from str to int #34482

merged 3 commits into from
Apr 17, 2023

Conversation

scv119
Copy link
Contributor

@scv119 scv119 commented Apr 17, 2023 •
edited
Loading

Why are these changes needed?

convert the variable from str to int to close #33963

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@scv119 scv119 linked an issue Apr 17, 2023 that may be closed by this pull request
[Core] os.getenv(ray_constants.GCS_PORT_ENVIRONMENT_VARIABLE)-- returned by getenv() is a string, but ray was not converted to int when used #33963
Closed
@scv119 scv119 marked this pull request as ready for review April 17, 2023 19:05
@jjyao
Copy link
Collaborator

jjyao commented Apr 17, 2023

Duplicate: #34367

rickyyx
rickyyx approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@rickyyx rickyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cadedaniel
cadedaniel approved these changes Apr 17, 2023
View reviewed changes
python/ray/tests/test_basic_5.py
os.environ["RAY_GCS_SERVER_PORT"] = "12345"
ray.init()
except RuntimeError:
pass
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: assert string value has some correct value so we don't hide other issues?

python/ray/tests/test_basic_5.py Outdated Show resolved Hide resolved
@scv119 scv119 merged commit f349823 into ray-project:master Apr 17, 2023
@rkooo567 rkooo567 mentioned this pull request Apr 18, 2023
Closed
8 tasks
elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
@scv119 @elliottower
[Core] convert gcs port read from env variable from str to int (ray-p…
fc569e5 
…roject#34482)

convert the variable from str to int to close ray-project#33963

Signed-off-by: elliottower <[email protected]>
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
@scv119 @ProjectsByJackHe
[Core] convert gcs port read from env variable from str to int (ray-p…
4c5ca56 
…roject#34482)

convert the variable from str to int to close ray-project#33963

Signed-off-by: Jack He <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickyyx rickyyx rickyyx approved these changes

@cadedaniel cadedaniel cadedaniel approved these changes

Assignees

@cadedaniel cadedaniel

@rickyyx rickyyx

@rkooo567 rkooo567

Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@scv119 @jjyao @cadedaniel @rickyyx @rkooo567