Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] [KubeRay] Add tutorial for connecting to google cloud storage bucket from GKE RayCluster #38858

Merged
merged 66 commits into from
Aug 31, 2023

Conversation

architkulkarni
Copy link
Contributor

@architkulkarni architkulkarni commented Aug 24, 2023

Why are these changes needed?

This PR adds a self contained tutorial for connecting to a google cloud storage bucket. (Mostly self contained, we do link out to the google cloud docs for creating a bucket.)

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

kevin85421 and others added 30 commits August 20, 2023 16:58
…nchmark.md

Co-authored-by: angelinalg <[email protected]>
Signed-off-by: Kai-Hsun Chen <[email protected]>
…nchmark.md

Co-authored-by: angelinalg <[email protected]>
Signed-off-by: Kai-Hsun Chen <[email protected]>
…nchmark.md

Co-authored-by: angelinalg <[email protected]>
Signed-off-by: Kai-Hsun Chen <[email protected]>
…nchmark.md

Co-authored-by: angelinalg <[email protected]>
Signed-off-by: Kai-Hsun Chen <[email protected]>
Co-authored-by: angelinalg <[email protected]>
Signed-off-by: Kai-Hsun Chen <[email protected]>
Co-authored-by: angelinalg <[email protected]>
Signed-off-by: Kai-Hsun Chen <[email protected]>
Co-authored-by: angelinalg <[email protected]>
Signed-off-by: Kai-Hsun Chen <[email protected]>
Co-authored-by: angelinalg <[email protected]>
Signed-off-by: Kai-Hsun Chen <[email protected]>
RAY_GCS_BUCKET = "my-bucket"
RAY_GCS_FILE = "test_file.txt"

ray.init(address="auto")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remote Ray processes can still access the bucket

If we install google-cloud-storage only on the head Pod, will a task scheduled on a worker node still succeed?

architkulkarni and others added 10 commits August 31, 2023 12:21
@architkulkarni
Copy link
Contributor Author

@kevin85421 Thanks, I addressed the comments

@architkulkarni
Copy link
Contributor Author

Addressed the dependency issue here. 58f81a7

architkulkarni added a commit to ray-project/kuberay that referenced this pull request Aug 31, 2023
Adds a new YAML file for the GKE bucket tutorial. Resolves ray-project/ray#38858 (comment)

---------

Signed-off-by: Archit Kulkarni <[email protected]>
@architkulkarni
Copy link
Contributor Author

Test failures:

  • FAILED bazel/::data-loading-preprocessing.rst
  • tests:test_multiprocessing
  • tests:test_task_events_2
  • tests:test_namespace

These are all unrelated

@architkulkarni architkulkarni added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Aug 31, 2023
@architkulkarni architkulkarni merged commit 3034965 into ray-project:master Aug 31, 2023
2 of 3 checks passed
architkulkarni added a commit to architkulkarni/ray that referenced this pull request Aug 31, 2023
…ucket from GKE RayCluster (ray-project#38858)

This PR adds a self contained tutorial for connecting to a google cloud storage bucket. (Mostly self contained, we do link out to the google cloud docs for creating a bucket.)

---------

Signed-off-by: Kai-Hsun Chen <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
Co-authored-by: Kai-Hsun Chen <[email protected]>
Co-authored-by: Kai-Hsun Chen <[email protected]>
Co-authored-by: angelinalg <[email protected]>
GeneDer pushed a commit that referenced this pull request Sep 1, 2023
…38857) (#39186)

* [Doc] [KubeRay] Add tutorial for connecting to google cloud storage bucket from GKE RayCluster (#38858)

This PR adds a self contained tutorial for connecting to a google cloud storage bucket. (Mostly self contained, we do link out to the google cloud docs for creating a bucket.)

---------

Signed-off-by: Kai-Hsun Chen <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
Co-authored-by: Kai-Hsun Chen <[email protected]>
Co-authored-by: Kai-Hsun Chen <[email protected]>
Co-authored-by: angelinalg <[email protected]>

* [Doc] [KubeRay] Add end-to-end tutorial for real-world RayJob workload (batch inference) (#38857)

This PR adds a tutorial for running a batch inference workload on KubeRay using the RayJob CRD.

It also updates the GPU/GKE doc (which is used as a subroutine in this tutorial) to remove the instructions related to taints and tolerations and GPU driver installation, both of which are currently handled automatically by GKE.

---------

Signed-off-by: Kai-Hsun Chen <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
Co-authored-by: Kai-Hsun Chen <[email protected]>
Co-authored-by: Kai-Hsun Chen <[email protected]>
Co-authored-by: angelinalg <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>

---------

Signed-off-by: Kai-Hsun Chen <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
Co-authored-by: Kai-Hsun Chen <[email protected]>
Co-authored-by: Kai-Hsun Chen <[email protected]>
Co-authored-by: angelinalg <[email protected]>
LeonLuttenberger pushed a commit to jaidisido/ray that referenced this pull request Sep 5, 2023
…ucket from GKE RayCluster (ray-project#38858)

This PR adds a self contained tutorial for connecting to a google cloud storage bucket. (Mostly self contained, we do link out to the google cloud docs for creating a bucket.)

---------

Signed-off-by: Kai-Hsun Chen <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
Co-authored-by: Kai-Hsun Chen <[email protected]>
Co-authored-by: Kai-Hsun Chen <[email protected]>
Co-authored-by: angelinalg <[email protected]>
jimthompson5802 pushed a commit to jimthompson5802/ray that referenced this pull request Sep 12, 2023
…ucket from GKE RayCluster (ray-project#38858)

This PR adds a self contained tutorial for connecting to a google cloud storage bucket. (Mostly self contained, we do link out to the google cloud docs for creating a bucket.)

---------

Signed-off-by: Kai-Hsun Chen <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
Co-authored-by: Kai-Hsun Chen <[email protected]>
Co-authored-by: Kai-Hsun Chen <[email protected]>
Co-authored-by: angelinalg <[email protected]>
Signed-off-by: Jim Thompson <[email protected]>
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
Adds a new YAML file for the GKE bucket tutorial. Resolves ray-project/ray#38858 (comment)

---------

Signed-off-by: Archit Kulkarni <[email protected]>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
…ucket from GKE RayCluster (ray-project#38858)

This PR adds a self contained tutorial for connecting to a google cloud storage bucket. (Mostly self contained, we do link out to the google cloud docs for creating a bucket.)

---------

Signed-off-by: Kai-Hsun Chen <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
Co-authored-by: Kai-Hsun Chen <[email protected]>
Co-authored-by: Kai-Hsun Chen <[email protected]>
Co-authored-by: angelinalg <[email protected]>
Signed-off-by: Victor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants