Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] [KubeRay] Add tutorial for connecting to google cloud storage bucket from GKE RayCluster #38858
[Doc] [KubeRay] Add tutorial for connecting to google cloud storage bucket from GKE RayCluster #38858
Changes from 42 commits
d34a528
8030e26
7f1c300
f2ab31b
7225343
b92099f
9d602ba
e5564a8
26bc93a
7a573d3
743f078
70928ce
e7f4a58
0a46948
5d2b814
702f129
dbe0bb5
b5b6437
8c0dab7
3f43229
c8e4fbc
856d8bc
5b7c2b0
4d86c7c
d2df3ed
76831fd
99a97d7
7bc8d3d
22730dd
2f2794d
21dceba
6909059
6f18b98
5a52048
d43ec07
2c4f191
3eb8b50
ec19d15
442dade
5bc0af2
2340e6a
4f85260
5c052db
347641c
ad016d3
44789e4
6f28325
fef5823
f62c720
b1f4d50
286c783
b39f7b5
098ac6c
677e0b0
fb279fe
77875d1
0cdf429
484e028
f835f3e
ea8e899
7746a44
e163585
9dd9691
cbfaa0c
671ee6c
58f81a7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is
roles/iam.workloadIdentityUser
from?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about the details. I think it's a predefined role built into GCP. The user can find more details at https://cloud.google.com/kubernetes-engine/docs/how-to/workload-identity which is linked in the doc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove
labels
here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to use Ray?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to use Ray. My thought was that people using KubeRay use Ray and this just demonstrates that remote Ray processes can still access the bucket (and you don't have to do anything weird with environment variables, etc). If it's confusing I can get rid of it, I don't have a strong opinion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we install
google-cloud-storage
only on the head Pod, will a task scheduled on a worker node still succeed?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It needs to be installed on all pods. Alternatively, one can specify
ray.init(runtime_env={"pip": ["google-cloud-storage"]})