Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set _remote() function args and kwargs as optional #4305

Merged
merged 5 commits into from
Mar 10, 2019

Conversation

justinwyang
Copy link
Contributor

@justinwyang justinwyang commented Mar 8, 2019

Fixes #4300.

@robertnishihara
Copy link
Collaborator

Can you augment this test so that it creates an actor and calls an actor method without passing in any values for args and kwargs just to make sure that it works?

def test_submit_api(shutdown_only):

@justinwyang justinwyang closed this Mar 8, 2019
@justinwyang justinwyang deleted the _remote_args_optional branch March 8, 2019 05:49
@justinwyang justinwyang restored the _remote_args_optional branch March 8, 2019 05:50
@justinwyang justinwyang reopened this Mar 8, 2019
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12691/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12689/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12696/
Test FAILed.

Copy link
Collaborator

@robertnishihara robertnishihara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I left a few comments. It looks like there is a pre-existing bug in the test that you've uncovered.

python/ray/tests/test_basic.py Outdated Show resolved Hide resolved
python/ray/tests/test_basic.py Outdated Show resolved Hide resolved
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12722/
Test PASSed.

Copy link
Collaborator

@robertnishihara robertnishihara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justinwyang I pushed some minor linting changes, this looks great! I'll merge this once the tests pass.

@robertnishihara robertnishihara merged commit 5adb4a6 into ray-project:master Mar 10, 2019
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12728/
Test PASSed.

@justinwyang justinwyang deleted the _remote_args_optional branch March 16, 2019 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants