-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set _remote() function args and kwargs as optional #4305
Set _remote() function args and kwargs as optional #4305
Conversation
Can you augment this test so that it creates an actor and calls an actor method without passing in any values for ray/python/ray/tests/test_basic.py Line 830 in 4c80177
|
Test FAILed. |
Test FAILed. |
Test FAILed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I left a few comments. It looks like there is a pre-existing bug in the test that you've uncovered.
Test PASSed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@justinwyang I pushed some minor linting changes, this looks great! I'll merge this once the tests pass.
Test PASSed. |
Fixes #4300.