Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set _remote() function args and kwargs as optional #4305

Merged
merged 5 commits into from
Mar 10, 2019
Merged

Set _remote() function args and kwargs as optional #4305

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8c0a373
Set _remote() function args and kwargs as optional
justinwyang Mar 8, 2019
7642f89
Added tests for args and kwargs
justinwyang Mar 8, 2019
159a680
Fixed indenting and _remote testing issues
justinwyang Mar 9, 2019
45a69ed
Update test_basic.py
robertnishihara Mar 9, 2019
728b419
Update test_basic.py
robertnishihara Mar 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions python/ray/actor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ def __call__(self, *args, **kwargs):
def remote(self, *args, **kwargs):
return self._remote(args, kwargs)

def _remote(self, args, kwargs, num_return_vals=None):
def _remote(self, args=None, kwargs=None, num_return_vals=None):
justinwyang marked this conversation as resolved.
Show resolved Hide resolved
if num_return_vals is None:
num_return_vals = self._num_return_vals

Expand Down Expand Up @@ -233,8 +233,8 @@ def remote(self, *args, **kwargs):
return self._remote(args=args, kwargs=kwargs)

def _remote(self,
args,
kwargs,
args=None,
kwargs=None,
num_cpus=None,
num_gpus=None,
resources=None):
Expand Down