[Data] Remove prefetch_blocks parameter of batch-based iteration APIs
#43347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Balaji Veeramani <[email protected]>
bveeramani
requested review from
ericl,
scv119,
c21,
amogkam,
scottjlee,
raulchen,
stephanie-wang and
omatthew98
as code owners
8 tasks
Signed-off-by: Balaji Veeramani <[email protected]>
c21
reviewed
Feb 22, 2024
There was a problem hiding this comment.
What about https://github.com/ray-project/ray/blob/master/python/ray/data/dataset.py#L3625 do we want to have a plan for this?
|
Signed-off-by: Balaji Veeramani <[email protected]>
c21
approved these changes
Feb 22, 2024
bveeramani
added a commit
that referenced
this pull request
Feb 22, 2024
) This PR deprecates the prefetch_blocks in favor of a new prefetch_batches parameter for consistency with other iteration APIs, which have used prefetch_batches since Ray 2.4 (see #43347) --------- Signed-off-by: Balaji Veeramani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Since Ray 2.4, we raise an error when users use the
prefetch_blocksparameter of iteration APIs likeiter_batches(users are instructed to useprefetch_batchesinstead). This PR removes the parameter entirely and any associated dead code.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.