[Data] Soft deprecate prefetch_blocks parameter of iter_rows
#43349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Balaji Veeramani <[email protected]>
bveeramani
requested review from
ericl,
scv119,
c21,
amogkam,
scottjlee,
raulchen,
stephanie-wang and
omatthew98
as code owners
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
8 tasks
c21
reviewed
Feb 22, 2024
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
c21
approved these changes
Feb 22, 2024
8 tasks
bveeramani
added a commit
that referenced
this pull request
Apr 26, 2024
…ault value (#44982) This PR deprecates the `prefetch_batches` parameter of `Dataset.iter_rows` because it leaks an implementation detail (namely, that we use `Dataset.iter_batches` under-the-hood). This PR also increases the default value for 1) consistency with `iter_batches` and 2) to improve performance. For historical context, #43349 erroneously introduced the `prefetch_batches` parameter. Signed-off-by: Balaji Veeramani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR deprecates the
prefetch_blocksin favor of a newprefetch_batchesparameter for consistency with other iteration APIs, which have usedprefetch_batchessince Ray 2.4 (see #43347)Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.