Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Inconsistent weight assignment operations in DQNPolicyGraph (#4… #4504

Merged
merged 2 commits into from
Mar 29, 2019
Merged

Fixes Inconsistent weight assignment operations in DQNPolicyGraph (#4… #4504

merged 2 commits into from
Mar 29, 2019

Conversation

vuoristo
Copy link
Contributor

@vuoristo vuoristo commented Mar 28, 2019 •
edited by ericl
Loading

What do these changes do?

Fixes "Inconsistent weight assignment operations in DQNPolicyGraph #4502" by removing unnecessary sorted from DQNPolicyGraph.__init__.

Related issue number

Fixes #4502

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

ericl
ericl approved these changes Mar 29, 2019
View reviewed changes
Copy link
Contributor

@ericl ericl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! I also added an assert

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13341/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13342/
Test FAILed.

@ericl
Copy link
Contributor

ericl commented Mar 29, 2019

jenkins retest this please

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/311/
Test PASSed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13348/
Test FAILed.

@ericl
Copy link
Contributor

ericl commented Mar 29, 2019

Test failure unrelated.

@ericl ericl merged commit 798944f into ray-project:master Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericl ericl ericl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent weight assignment operations in DQNPolicyGraph
3 participants
@vuoristo @AmplabJenkins @ericl