Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Inconsistent weight assignment operations in DQNPolicyGraph (#4… #4504

Merged
merged 2 commits into from
Mar 29, 2019
Merged

Fixes Inconsistent weight assignment operations in DQNPolicyGraph (#4… #4504

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b00b1f4
Fixes Inconsistent weight assignment operations in DQNPolicyGraph (#4…
vuoristo Mar 28, 2019
b634e81
Update dqn_policy_graph.py
ericl Mar 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions python/ray/rllib/agents/dqn/dqn_policy_graph.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,9 +387,9 @@ def __init__(self, observation_space, action_space, config):
# update_target_fn will be called periodically to copy Q network to
# target Q network
update_target_expr = []
for var, var_target in zip(
sorted(self.q_func_vars, key=lambda v: v.name),
sorted(self.target_q_func_vars, key=lambda v: v.name)):
assert len(self.q_func_vars) == len(self.target_q_func_vars), \
(self.q_func_vars, self.target_q_func_vars)
for var, var_target in zip(self.q_func_vars, self.target_q_func_vars):
update_target_expr.append(var_target.assign(var))
self.update_target_expr = tf.group(*update_target_expr)

Expand Down