-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HPU] [Serve] [experimental] Add vllm HPU support in vllm example #45893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KepingYan
requested review from
edoakes,
shrekris-anyscale,
zcin,
GeneDer,
akshay-anyscale and
a team
as code owners
June 12, 2024 09:00
Signed-off-by: KepingYan <[email protected]>
Signed-off-by: KepingYan <[email protected]>
Signed-off-by: KepingYan <[email protected]>
Signed-off-by: KepingYan <[email protected]>
Signed-off-by: KepingYan <[email protected]>
KepingYan
changed the title
[HPU] [Serve] Add vllm HPU support in vllm example
[HPU] [Serve] [experimental] Add vllm HPU support in vllm example
Jun 21, 2024
can-anyscale
reviewed
Jul 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
has been several weeks, @akshay-anyscale , @edoakes do you mind have a look, thanks
akshay-anyscale
approved these changes
Jul 2, 2024
Signed-off-by: KepingYan <[email protected]>
Signed-off-by: KepingYan <[email protected]>
Signed-off-by: KepingYan <[email protected]>
KepingYan
force-pushed
the
add_vllm_hpu
branch
from
August 13, 2024 11:50
1ff2528
to
0e03169
Compare
KepingYan
force-pushed
the
add_vllm_hpu
branch
from
August 13, 2024 12:01
1ff2528
to
cd391ed
Compare
Signed-off-by: KepingYan <[email protected]>
Signed-off-by: KepingYan <[email protected]>
Signed-off-by: KepingYan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR adds vllm HPU support in vllm example (#45430). The added codes will check whether the HPU device exists before allocating resources to vllm actors. If it exists, HPU resources are used, otherwise GPU resources are still used.
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.