Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data] Change fixture from shutdown_only to ray_start_regular_shared for test_csv_read_filter_non_csv_file #47513

Merged
merged 1 commit into from
Sep 9, 2024
Merged

[data] Change fixture from shutdown_only to ray_start_regular_shared for test_csv_read_filter_non_csv_file #47513

merged 1 commit into from
Sep 9, 2024

Conversation

omatthew98
Copy link
Contributor

Why are these changes needed?

Seems that #47467 ended up breaking some niche setup for this test, by changing the fixture from shutdown_only to ray_start_regular_shared we are able to get the test passing again.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@omatthew98 omatthew98 added the go add ONLY when ready to merge, run all tests label Sep 5, 2024
@scottjlee scottjlee merged commit e4513e5 into ray-project:master Sep 9, 2024
5 checks passed
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@omatthew98 @ujjawal-khare
[data] Change fixture from shutdown_only to `ray_start_regular_shar…
75c03f2 
…ed` for `test_csv_read_filter_non_csv_file` (ray-project#47513)

## Why are these changes needed?
Seems that ray-project#47467 ended up
breaking some niche setup for this test, by changing the fixture from
`shutdown_only` to `ray_start_regular_shared` we are able to get the
test passing again.

## Related issue number

## Checks

- [x] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [x] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [x] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [x] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

Signed-off-by: Matthew Owen <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@omatthew98 @ujjawal-khare
[data] Change fixture from shutdown_only to `ray_start_regular_shar…
eda80d5 
…ed` for `test_csv_read_filter_non_csv_file` (ray-project#47513)

## Why are these changes needed?
Seems that ray-project#47467 ended up
breaking some niche setup for this test, by changing the fixture from
`shutdown_only` to `ray_start_regular_shared` we are able to get the
test passing again.

## Related issue number

## Checks

- [x] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [x] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [x] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [x] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

Signed-off-by: Matthew Owen <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@omatthew98 @ujjawal-khare
[data] Change fixture from shutdown_only to `ray_start_regular_shar…
fa82995 
…ed` for `test_csv_read_filter_non_csv_file` (ray-project#47513)

## Why are these changes needed?
Seems that ray-project#47467 ended up
breaking some niche setup for this test, by changing the fixture from
`shutdown_only` to `ray_start_regular_shared` we are able to get the
test passing again.

## Related issue number

## Checks

- [x] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [x] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [x] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [x] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

Signed-off-by: Matthew Owen <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@omatthew98 @ujjawal-khare
[data] Change fixture from shutdown_only to `ray_start_regular_shar…
914a069 
…ed` for `test_csv_read_filter_non_csv_file` (ray-project#47513)

## Why are these changes needed?
Seems that ray-project#47467 ended up
breaking some niche setup for this test, by changing the fixture from
`shutdown_only` to `ray_start_regular_shared` we are able to get the
test passing again.

## Related issue number

## Checks

- [x] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [x] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [x] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [x] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

Signed-off-by: Matthew Owen <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@omatthew98 @ujjawal-khare
[data] Change fixture from shutdown_only to `ray_start_regular_shar…
8e19202 
…ed` for `test_csv_read_filter_non_csv_file` (ray-project#47513)

## Why are these changes needed?
Seems that ray-project#47467 ended up
breaking some niche setup for this test, by changing the fixture from
`shutdown_only` to `ray_start_regular_shared` we are able to get the
test passing again.

## Related issue number

## Checks

- [x] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [x] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [x] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [x] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

Signed-off-by: Matthew Owen <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@omatthew98 @ujjawal-khare
[data] Change fixture from shutdown_only to `ray_start_regular_shar…
988ba9e 
…ed` for `test_csv_read_filter_non_csv_file` (ray-project#47513)

## Why are these changes needed?
Seems that ray-project#47467 ended up
breaking some niche setup for this test, by changing the fixture from
`shutdown_only` to `ray_start_regular_shared` we are able to get the
test passing again.

## Related issue number

## Checks

- [x] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [x] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [x] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [x] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

Signed-off-by: Matthew Owen <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@omatthew98 @ujjawal-khare
[data] Change fixture from shutdown_only to `ray_start_regular_shar…
b771f10 
…ed` for `test_csv_read_filter_non_csv_file` (ray-project#47513)

## Why are these changes needed?
Seems that ray-project#47467 ended up
breaking some niche setup for this test, by changing the fixture from
`shutdown_only` to `ray_start_regular_shared` we are able to get the
test passing again.

## Related issue number

## Checks

- [x] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [x] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [x] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [x] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

Signed-off-by: Matthew Owen <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@omatthew98 @ujjawal-khare
[data] Change fixture from shutdown_only to `ray_start_regular_shar…
ca79865 
…ed` for `test_csv_read_filter_non_csv_file` (ray-project#47513)

## Why are these changes needed?
Seems that ray-project#47467 ended up
breaking some niche setup for this test, by changing the fixture from
`shutdown_only` to `ray_start_regular_shared` we are able to get the
test passing again.

## Related issue number

## Checks

- [x] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [x] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [x] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [x] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

Signed-off-by: Matthew Owen <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@omatthew98 @ujjawal-khare
[data] Change fixture from shutdown_only to `ray_start_regular_shar…
9eef3b5 
…ed` for `test_csv_read_filter_non_csv_file` (ray-project#47513)

## Why are these changes needed?
Seems that ray-project#47467 ended up
breaking some niche setup for this test, by changing the fixture from
`shutdown_only` to `ray_start_regular_shared` we are able to get the
test passing again.

## Related issue number

## Checks

- [x] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [x] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [x] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [x] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

Signed-off-by: Matthew Owen <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottjlee scottjlee scottjlee approved these changes

@ericl ericl Awaiting requested review from ericl

@scv119 scv119 Awaiting requested review from scv119

@c21 c21 Awaiting requested review from c21

@amogkam amogkam Awaiting requested review from amogkam

@bveeramani bveeramani Awaiting requested review from bveeramani bveeramani is a code owner

@raulchen raulchen Awaiting requested review from raulchen raulchen is a code owner

@stephanie-wang stephanie-wang Awaiting requested review from stephanie-wang stephanie-wang is a code owner

@can-anyscale can-anyscale Awaiting requested review from can-anyscale

Assignees
No one assigned
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omatthew98 @scottjlee